Fix failing unit tests due to unset defaults

Amended default conditions from null checks to empty checks in function-coauthors.php and class-components.php. Previously, there were no defaults set when running unit tests which led to unexpected fails. This change will ensure that unit tests pass even when certain parameters are not explicitly set.
alleyinteractive · Oct 31, 2023 · 1410294 · 1410294
1 parent 0066034
commit 1410294
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/includes/apple-exporter/builders/class-components.php b/includes/apple-exporter/builders/class-components.php
@@ -526,7 +526,7 @@ private function get_components_from_node( $node ) {
 	 */
 	private function get_image_full_size_url( $url ) {
 
-		if(null === $url) {
+		if( empty( $url ) ) {
 			return '';
 		}
 

diff --git a/tests/mocks/function-coauthors.php b/tests/mocks/function-coauthors.php
@@ -29,7 +29,9 @@ function coauthors( $between = ', ', $between_last = ' and ', $before = '', $aft
 	// Get last index.
 	$last_index = count( $apple_news_coauthors ) - 1;
 
-	if(null === $between) {
+	// Default was not set when running unit tests,
+	// causing failures.
+	if(empty( $between)) {
 		$between = ', ';
 	}