Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SKYEDEN-3082 tracker link in console #1940

Merged
merged 13 commits into from
Jan 8, 2025

Conversation

questras
Copy link
Collaborator

@questras questras commented Dec 19, 2024

Added tracking card for both topic and subscription view. For url provider, only interface is provided - it needs to be implemented in order to show actual links (examples in images)

  1. When tracking is enabled but no urls are provided, then appropriate message is shown (shown in the screenshot)
  2. When urls are provided, both topic and subscription views show all links with their names in tracking card
  3. If tracking is disabled then the tracking card does not appear (nothing in the ui changes)
    Screenshot 2024-12-19 at 16 14 03
    Screenshot 2024-12-19 at 16 14 25
    Screenshot 2024-12-19 at 16 14 42

@questras questras marked this pull request as ready for review December 20, 2024 14:10
import io.swagger.annotations.Api;
import io.swagger.annotations.ApiOperation;
import jakarta.annotation.security.RolesAllowed;
import jakarta.ws.rs.*;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: "*" import

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@questras questras requested a review from szczygiel-m January 3, 2025 09:25
@moscicky moscicky self-requested a review January 8, 2025 09:14
@moscicky moscicky merged commit 829b93a into master Jan 8, 2025
12 of 13 checks passed
@szczygiel-m szczygiel-m deleted the SKYEDEN-3082-tracker-link-in-console branch January 8, 2025 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants