SKYEDEN-3271 |hermes management leader #1934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
questras
requested changes
Dec 3, 2024
| @@ -85,4 +89,12 @@ public SubscriptionLagSource consumerLagSource() { | |||
| public Clock clock() { | |||
| return new ClockFactory().provide(); | |||
| } | |||
|
|
|||
| @Bean | |||
| ManagementLeadership inactiveTopicsDetectionLeader( | |||
There was a problem hiding this comment.
Suggested change
| ManagementLeadership inactiveTopicsDetectionLeader( | |
| ManagementLeadership managementLeadership( |
| detection.inactive-topics.cron | cron expression for the detection job | 0 0 8 * * * | ||
| detection.inactive-topics.notifications-history-limit | how many notification timestamps will be kept in history | 5 | ||
|
|
||
| The detection job runs on a single instance of Hermes Management that is a | ||
| leader based on the leader election Zookeeper instance. | ||
|
|
||
| | Option | Description | Default Value | | ||
| |-------------------------------------|----------------------------------------------------------------------------|---------------| | ||
| | management.leadership.zookeeper-dc | Specifies the datacenter of the Zookeeper instance used for leader election in the detection job | dc | |
There was a problem hiding this comment.
Looks like the formatting is off because of the too long Description.
Moreover, maybe description should be updated here? It still refers to detection job
questras
approved these changes
Dec 3, 2024
MarcinBobinski
merged commit 894f8bd
into
SKYEDEN-3234-detect-unused-topics
3 checks passed
szczygiel-m
pushed a commit
that referenced
this pull request
Dec 20, 2024
* SKYEDEN-3234 | Add marking and unmarking commands * SKYEDEN-3234 | Change to batch upserting * SKYEDEN-3234 | Implement zk unusted topics repo * SKYEDEN-3234 | Implement unused topics service * SKYEDEN-3234 | Add repo for last published message timestamp * SKYEDEN-3234 | Rename from read to get * SKYEDEN-3234 | Change last notified to list with timestamps * SKYEDEN-3234 | Implement unused topics detection job * SKYEDEN-3234 | Add tests for unused topics detection * SKYEDEN-3234 | Add detection job test * SKYEDEN-3234 | Refactor detection job test * SKYEDEN-3234 | Make unused topics notifier bean optional * SKYEDEN-3234 | Add scheduling * SKYEDEN-3234 | Add properties with default values * SKYEDEN-3234 | Add more logging and refactor * SKYEDEN-3234 | Rename from unused to inactive * SKYEDEN-3234 | Handle lack of last published message metrics * SKYEDEN-3234 | Do not call notifier when no inactive topics * SKYEDEN-3234 | Fix style * SKYEDEN-3234 | Add log when detection starts * SKYEDEN-3234 | Fix style * SKYEDEN-3234 | Add more logging * SKYEDEN-3234 | Move leader and config to separate classes * SKYEDEN-3234 | Change log message * SKYEDEN-3234 | Remove unnecessary annotation * SKYEDEN-3234 | Do not update notification timestamps when notification skipped * SKYEDEN-3234 | Add docs for inactive topics detection * SKYEDEN-3234 | Add notification result as return type of notifier * SKYEDEN-3234 | Add owner info to be used by notifier * SKYEDEN-3234 | Limit number of notification timestamps in history * SKYEDEN-3234 | Update docs * SKYEDEN-3234 | Specify shorter names to be saved in json * SKYEDEN-3271 |hermes management leader (#1934) * SKYEDEN-3271 |hermes management leader * SKYEDEN-3271 | cr changes * SKYEDEN-3234 | Remove unused property * SKYEDEN-3271 | fix leader path * Revert "Merge branch 'master' into SKYEDEN-3234-detect-unused-topics" This reverts commit 9545569, reversing changes made to 8194321. * Revert "Revert "Merge branch 'master' into SKYEDEN-3234-detect-unused-topics"" This reverts commit cf17940. * SKYEDEN-3234 | Add metrics for number of inactive topics * SKYEDEN-3234 | Remove * import --------- Co-authored-by: Marcin Bobiński <[email protected]> Co-authored-by: Marcin Bobinski <[email protected]>
szczygiel-m
pushed a commit
that referenced
this pull request
Dec 20, 2024
* SKYEDEN-3234 | Add marking and unmarking commands * SKYEDEN-3234 | Change to batch upserting * SKYEDEN-3234 | Implement zk unusted topics repo * SKYEDEN-3234 | Implement unused topics service * SKYEDEN-3234 | Add repo for last published message timestamp * SKYEDEN-3234 | Rename from read to get * SKYEDEN-3234 | Change last notified to list with timestamps * SKYEDEN-3234 | Implement unused topics detection job * SKYEDEN-3234 | Add tests for unused topics detection * SKYEDEN-3234 | Add detection job test * SKYEDEN-3234 | Refactor detection job test * SKYEDEN-3234 | Make unused topics notifier bean optional * SKYEDEN-3234 | Add scheduling * SKYEDEN-3234 | Add properties with default values * SKYEDEN-3234 | Add more logging and refactor * SKYEDEN-3234 | Rename from unused to inactive * SKYEDEN-3234 | Handle lack of last published message metrics * SKYEDEN-3234 | Do not call notifier when no inactive topics * SKYEDEN-3234 | Fix style * SKYEDEN-3234 | Add log when detection starts * SKYEDEN-3234 | Fix style * SKYEDEN-3234 | Add more logging * SKYEDEN-3234 | Move leader and config to separate classes * SKYEDEN-3234 | Change log message * SKYEDEN-3234 | Remove unnecessary annotation * SKYEDEN-3234 | Do not update notification timestamps when notification skipped * SKYEDEN-3234 | Add docs for inactive topics detection * SKYEDEN-3234 | Add notification result as return type of notifier * SKYEDEN-3234 | Add owner info to be used by notifier * SKYEDEN-3234 | Limit number of notification timestamps in history * SKYEDEN-3234 | Update docs * SKYEDEN-3234 | Specify shorter names to be saved in json * SKYEDEN-3271 |hermes management leader (#1934) * SKYEDEN-3271 |hermes management leader * SKYEDEN-3271 | cr changes * SKYEDEN-3234 | Remove unused property * SKYEDEN-3271 | fix leader path * Revert "Merge branch 'master' into SKYEDEN-3234-detect-unused-topics" This reverts commit 9545569, reversing changes made to 8194321. * Revert "Revert "Merge branch 'master' into SKYEDEN-3234-detect-unused-topics"" This reverts commit cf17940. * SKYEDEN-3234 | Ui for inactive topics WIP * SKYEDEN-3234 | Change v-table to v-data-table * SKYEDEN-3234 | Add link to inactive topics * SKYEDEN-3234 | Add endpoint for inactive topics * SKYEDEN-3234 | show error when cannot fetch inactive topics * SKYEDEN-3234 | linting * SKYEDEN-3234 | Remove unnecessary fields * SKYEDEN-3234 | Add test for InactiveTopicsView * SKYEDEN-3234 | Add test for InactiveTopicsListing * SKYEDEN-3234 | Add test for UseInactiveTopics --------- Co-authored-by: Marcin Bobiński <[email protected]> Co-authored-by: Marcin Bobinski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.