Skip to content
This repository has been archived by the owner on May 18, 2020. It is now read-only.

add es 7.x support #94

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

add es 7.x support #94

wants to merge 5 commits into from

Conversation

eynand
Copy link

@eynand eynand commented Oct 7, 2019

No description provided.

@eynand
Copy link
Author

eynand commented Oct 7, 2019

Hi,
I've added some limited support for es 7,x (only windows is supported), taking into account the _template changes and type removal.
my proposal is to keep thing working for earlier es versions, and let the users use a new "withMapping" instead of the old "withType" , this will allow the co-existence of versions.
all of the test is passing, I've also added another test suite for 7.3.
Eynan

@tholu
Copy link

tholu commented Nov 21, 2019

@eynand Why did the Travis builds fail?

@eynand
Copy link
Author

eynand commented Nov 21, 2019

It looks like install JDK 8 step is faliing.
do you think this got to do with the CL?

@bekihm
Copy link

bekihm commented Feb 20, 2020

@eynand Maybe it is a problem of travis using oraclejdk8:
https://travis-ci.community/t/error-installing-oraclejdk8-expected-feature-release-number-in-range-of-9-to-14-but-got-8/3766/5

Maybe the dist 'trusty' must be specified in the Travis file.

@bekihm
Copy link

bekihm commented Feb 20, 2020

@eynand I added an own PR of your changes with the changed travis setting dist trusty. Seems to run (We will see the results after build is done).
You may cherry pick my commit.

@pablotdl
Copy link

pablotdl commented Apr 8, 2020

Looks like it's the windows only support. I'll try and fork from your PR and fix it.

@pablotdl
Copy link

pablotdl commented Apr 10, 2020

Hi, I just created this PR so that it picks the right version: #98

@pablotdl
Copy link

pablotdl commented Apr 10, 2020

I got the tests to pass, not 100% happy with the way I did it. If anyone cares to review, I'd appreciate it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants