[OMON-793] Add dependency on kafka and protobuf in Monitoring #5712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sy-c
requested changes
Dec 9, 2024
|
we can close it for what I am concerned. |
|
Can this be closed? |
vascobarroso
previously approved these changes
Jan 24, 2025
|
@sy-c looks like one of the tests is failing, could you have a look ? |
compilation fix
|
@vascobarroso compile fix released |
vascobarroso
approved these changes
Jan 24, 2025
|
@ktf errors look unrelated to me. If that's the case, could you merge this ? We need it for early next week. Thanks! |
|
I assume you only need this for the o2-dataflow default? I'd rather not have a dependency on kafka for the general case. If yes, would you mind adding the customisation to the default? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.