Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't fail silently on HTTP upload attempt #890

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
+1 −4
Draft

Don't fail silently on HTTP upload attempt #890

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b45217d
Don't fail silently on HTTP upload attempt
singiamtel Nov 21, 2024
b3bc7ad
Fix tests
singiamtel Dec 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion alibuild_helpers/sync.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,7 @@ def fetch_symlinks(self, spec):
os.path.join(self.workdir, links_path, linkname))

def upload_symlinks_and_tarball(self, spec):
pass
dieOnError(True, "HTTP backend does not support uploading directly")


class RsyncRemoteSync:
Expand Down
3 changes: 0 additions & 3 deletions tests/test_sync.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,6 @@ def test_http_remote(self, mock_get, mock_error, mock_debug):
syncer.fetch_symlinks(GOOD_SPEC)
syncer.fetch_tarball(GOOD_SPEC)
mock_error.assert_not_called()
syncer.upload_symlinks_and_tarball(GOOD_SPEC)

# Try bad spec
mock_error.reset_mock()
Expand All @@ -128,8 +127,6 @@ def test_http_remote(self, mock_get, mock_error, mock_debug):
self.assertIsInstance(mock_error.call_args_list[0][0][2],
sync.PartialDownloadError)

syncer.upload_symlinks_and_tarball(BAD_SPEC)

# Try missing spec
mock_debug.reset_mock()
syncer.fetch_symlinks(MISSING_SPEC)
Expand Down
Loading