Multiple data type #84

arribbar · 2018-03-02T16:15:15Z

Example and Readme updated

iOS and Android

Allow sharing multi content
Share images, texts or urls
Return a list like : [{ type, value }, { type, value }]

Android

We get as well video and audio

…tension into multipleDataType

arribbar · 2018-03-12T09:43:28Z

@alinz Do you have some time to take a look at this PR, please ? :)

pierretanguay · 2018-03-22T17:24:16Z

Works perfectly for me. Tried it in a live project.

abarisic86 · 2018-04-27T15:01:55Z

How can one extend this to accept application/octet? That should be similar to audio/video? @arribbar
I'm trying to extend your PR with support for it but I have trouble starting the Sample Project. Another question, do we actually need android/src/main/java/com/github/... and child folders and files? It looks like duplicate old code.

kalek · 2018-08-24T13:46:06Z

@pierretanguay export chats from Whatsapp also works for you ?

arribbar · 2018-08-30T13:02:38Z

Oh, sorry @abarisic86, I haven't seen your message before. I'll try to take a look soon and make some corrections if needed

# |-------- 50 characters for the title --------| # If applied, this commit will... # |----------------- 72 characters for the body ----------------------| # Why is this change needed? How do you solve it ?

arribbar · 2018-09-20T16:26:33Z

@abarisic86 Do you still need help on this or not? I might have some time this weekend.

abarisic86 · 2018-09-20T20:34:01Z

hey, I couldn't set it up so I just discarded it, but thanks

…

On Thu, Sep 20, 2018 at 6:26 PM Bart Arribe ***@***.***> wrote: @abarisic86 <https://github.com/abarisic86> Do you still need help on this or not? I might have some time this weekend. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#84 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEuGE2_JpQlSqypm-CKPnL_-z6exa9LIks5uc8HPgaJpZM4SaIOm> .

arribbar · 2018-09-21T08:46:14Z

Ok, sorry for my late response

AndrewHenderson · 2018-11-09T02:35:05Z

@arribbar If you want this merged, please resolve conflicts. Thanks!

…sion into multipleDataType

…extension into multipleDataType

arribbar · 2018-11-09T10:03:51Z

@AndrewHenderson done. Thank you :)

isaachinman · 2018-11-09T17:28:43Z

@AndrewHenderson I've been using this in a live project for several months now, but I suppose it still needs to get reviewed and put on the roadmap.

AndrewHenderson · 2018-11-09T19:19:17Z

android/src/main/java/com/alinz/parkerdan/shareextension/RealPathUtil.java

@@ -9,6 +9,171 @@
 import android.content.ContentUris;
 import android.os.Environment;

+<<<<<<< HEAD


@arribbar Still seeing Git conflict commenting in this file. Please remove. Also, please check other files.

It's been awhile since you first submitted this, so please give review it from top to bottom. Thanks!

Oooh ****, I'll take a look at it this week and get back to you asap. Thank you and sorry for this error

arribbar · 2018-11-12T15:58:43Z

Ok, I tested it a bit on Android. I made a fix to get images from whatsapp but I wonder if we shouldn't change getDataColumn function by adding a catch and use copyFile function if we are in the exception.

Link to getDataColumn : 90a6207#diff-5068d814d5a6c28612588fdf7b19debdR91

What do you think @AndrewHenderson ?

AndrewHenderson · 2018-11-12T22:03:39Z

@arribbar I'm testing this on a Samsung Galaxy S8 running Android v8.0. I'm finding that the sharing of images from Photos results in a value of null rather than a path to the image.

arribbar · 2018-11-13T09:53:15Z

Hmm, that's super strange.
I am on a One Plus 5T on Android v8.1 and it works fine on my app. I checked it for one or several pictures as well as for videos on Photos, Gallery and Whatsapp

arribbar · 2018-11-13T11:07:18Z

@AndrewHenderson Can you provide me an example to test it ? I could not run the provided example by this project on Android :(

AndrewHenderson · 2018-11-13T21:37:47Z

@arribbar Thanks for providing device info.

I don't have a reduced test case I can send you. I'll work on getting the current example working or write a new one.

@isaachinman and I recently began assisting with the maintenance of this repo. Please bear with us as we get things moving smoothly again.

isaachinman · 2018-11-13T21:40:24Z

@AndrewHenderson Looks like the example hasn't been updated in a year. Any idea what it'll take to get that back up and running?

arribbar · 2018-11-19T13:13:31Z

@AndrewHenderson Can you provide me your running example ? I'll check the changes then that we need to do in order to make it work.
Thanks !

arribbar · 2018-11-27T16:09:59Z

Ok, @AndrewHenderson. Can you try again now ? It should work better now I think

AndrewHenderson · 2018-12-19T18:31:26Z

Can you provide me an example to test it ? I could not run the provided example by this project on Android :(

@arribbar I restored the working example on the following branch: https://github.com/alinz/react-native-share-extension/tree/example/examples/simple.

It is boilerplate and runs on Android. In order to run on iOS one needs to follow the iOS Setup in order to manage code signing, etc.

If you still need the lightweight sample can use to validate the issue I mentioned, you can use that.

@isaachinman I wonder if there is a way we can have the iOS example run without all the added setup?

isaachinman · 2018-12-20T11:07:25Z

I wonder if there is a way we can have the iOS example run without all the added setup?

As far as I know, each of the steps are absolutely required. For iOS we are basically creating a "second" app entirely, so it's never going to be a quick process.

I am not an iOS dev by trade though - perhaps someone knows better than I.

arribbar · 2018-12-20T13:57:25Z

I'll take a look at this soon
@AndrewHenderson Can you test with this last version ? I have made some improvements since you reviewed it and tell me if it is still not working for you or not :)

chaitanyadeorukhkar · 2019-04-22T10:17:19Z

Is this PR still active? How can I help to get this merged?

djorkaeffalexandre · 2019-05-09T00:44:18Z

@arribbar Do you plan fix that to merge? I want to use this library in my project on Google Summer of Code but I need support to multiple data.

Bart Arribe added 14 commits July 4, 2017 16:10

Add audio, video sharing for android

adf060f

Update example to make it work

7a6c3e8

Update example and readme

b6ad992

Retrieve path from other apps

bce7004

Add SEND_MULTIPLE and return array for android

ce00a3f

Update android example

d595c62

Update Readme and example

f49b63c

Reindent properly two Java files

27cef78

Merge remote-tracking branch 'upstream/master' into multipleDataType

c1beafb

Remove non-used createJSModules (RN 0.47)

fbd9cea

Merge branch 'master' of git://github.com/alinz/react-native-share-ex…

77f8b1d

…tension into multipleDataType

keep image orientation in temp file saved

25737ad

Enable sharing multi content

f76c216

Update example and readme

f8c9415

Get IMAGE_IDENTIFIER first in case we get a path

ebdeec7

isaachinman mentioned this pull request Mar 25, 2018

Share image from other application ( Whatsapp, facebook, strava, google photos, etc ) only on android #82

Open

AudreyBramy and others added 3 commits September 12, 2018 15:29

Upgrade compileSdk and buildTools version

dd69a60

# |-------- 50 characters for the title --------| # If applied, this commit will... # |----------------- 72 characters for the body ----------------------| # Why is this change needed? How do you solve it ?

Upgrade compileSdk and buildTools version

57de8db

# |-------- 50 characters for the title --------| # If applied, this commit will... # |----------------- 72 characters for the body ----------------------| # Why is this change needed? How do you solve it ?

Update build.gradle

94017b7

Bart Arribe added 2 commits November 9, 2018 10:46

Merge branch 'master' of github.com:arribbar/react-native-share-exten…

06c690f

…sion into multipleDataType

Merge branch 'master' of https://github.com/alinz/react-native-share-…

269977c

…extension into multipleDataType

arribbar mentioned this pull request Nov 9, 2018

Add support for application mime-type & remove redundant files arribbar/react-native-share-extension#1

Closed

AndrewHenderson requested changes Nov 9, 2018

View reviewed changes

This was referenced Nov 9, 2018

Roadmap - new maintainers #123

Open

Support multiple attachments #32

Open

support multi-images and content uri real path resolving #34

Open

Bart Arribe added 2 commits November 12, 2018 12:01

Fix error in resolving conflicts in merge

f747bc6

Get image from Whatsapp

90a6207

Copy file only if we cannot get data column

7c15c0b

Bart Arribe added 2 commits November 28, 2018 10:36

Get file from mms with mms in Authority

7c6128e

Fix dumb import

0f2b7c7

isaachinman mentioned this pull request Mar 14, 2019

Plans to support native share extension without detaching? expo/expo#48

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Multiple data type #84

Multiple data type #84

arribbar commented Mar 2, 2018

arribbar commented Mar 12, 2018

pierretanguay commented Mar 22, 2018

abarisic86 commented Apr 27, 2018 •

edited

Loading

kalek commented Aug 24, 2018

arribbar commented Aug 30, 2018

arribbar commented Sep 20, 2018

abarisic86 commented Sep 20, 2018 via email

arribbar commented Sep 21, 2018

AndrewHenderson commented Nov 9, 2018

arribbar commented Nov 9, 2018

isaachinman commented Nov 9, 2018

AndrewHenderson Nov 9, 2018 •

edited

Loading

arribbar Nov 12, 2018

arribbar commented Nov 12, 2018

AndrewHenderson commented Nov 12, 2018

arribbar commented Nov 13, 2018

arribbar commented Nov 13, 2018

AndrewHenderson commented Nov 13, 2018

isaachinman commented Nov 13, 2018

arribbar commented Nov 19, 2018

arribbar commented Nov 27, 2018

AndrewHenderson commented Dec 19, 2018

isaachinman commented Dec 20, 2018

arribbar commented Dec 20, 2018

chaitanyadeorukhkar commented Apr 22, 2019

djorkaeffalexandre commented May 9, 2019

Multiple data type #84

Are you sure you want to change the base?

Multiple data type #84

Conversation

arribbar commented Mar 2, 2018

iOS and Android

Android

arribbar commented Mar 12, 2018

pierretanguay commented Mar 22, 2018

abarisic86 commented Apr 27, 2018 • edited Loading

kalek commented Aug 24, 2018

arribbar commented Aug 30, 2018

arribbar commented Sep 20, 2018

abarisic86 commented Sep 20, 2018 via email

arribbar commented Sep 21, 2018

AndrewHenderson commented Nov 9, 2018

arribbar commented Nov 9, 2018

isaachinman commented Nov 9, 2018

AndrewHenderson Nov 9, 2018 • edited Loading

Choose a reason for hiding this comment

arribbar Nov 12, 2018

Choose a reason for hiding this comment

arribbar commented Nov 12, 2018

AndrewHenderson commented Nov 12, 2018

arribbar commented Nov 13, 2018

arribbar commented Nov 13, 2018

AndrewHenderson commented Nov 13, 2018

isaachinman commented Nov 13, 2018

arribbar commented Nov 19, 2018

arribbar commented Nov 27, 2018

AndrewHenderson commented Dec 19, 2018

isaachinman commented Dec 20, 2018

arribbar commented Dec 20, 2018

chaitanyadeorukhkar commented Apr 22, 2019

djorkaeffalexandre commented May 9, 2019

abarisic86 commented Apr 27, 2018 •

edited

Loading

AndrewHenderson Nov 9, 2018 •

edited

Loading