Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added SkyLang #98

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

gorentbarak
Copy link

No description provided.

@gorentbarak gorentbarak changed the title added skylang Added SkyLang Nov 30, 2023
@alilleybrinker
Copy link
Owner

It looks like this change adds the language to the README, but not to the JSON file which is used to build the README. Can you resubmit with the appropriate new entry in the JSON file, and then re-run the build script to rebuild the README?

@gorentbarak
Copy link
Author

Oh, I didn't realize :p.

@gorentbarak
Copy link
Author

@alilleybrinker I added Skylang to the JSON file and re-ran the script :).

@alerque
Copy link
Contributor

alerque commented Dec 5, 2023

This nukes a bunch of things that got added to the README but not the JSON data. I fixed those missing entries in my PR #100, I suggest that get merged first, then this get rebased on that with just the JSON update while re-running the readme generator to only add the new correct data without clobbering other entries.

@gorentbarak
Copy link
Author

@alerque oh, good idea. well, nice that you made a PR.

@gorentbarak
Copy link
Author

dont know why things got added to the readme and not json :/

@alerque
Copy link
Contributor

alerque commented Dec 6, 2023

My PR is merged that handles all the missing JSON data. You can rebase this PR now, but probably what you want to do is just cherry pick the second commit and only the changes to the JSON file, then re-run the readme updater. That should get around all the conflicts that are going to come up. If you like I can easily do that and submit a replacement PR.

@alilleybrinker
Copy link
Owner

Two things:

  1. There's now a conflict with the README. Can you re-apply your changes on top of main?
  2. It looks like you've committed a tags file, which should be removed from the PR

Once that's resolved this will be ready to merge!

@alerque
Copy link
Contributor

alerque commented Dec 8, 2023

I tried to cherry-pick just the change to the JSON data, but it turns out this project doesn't have a mirror on GitHub, and the tooling for this repo currently clobbers and deletes anything that doesn't lookup right via the GitHub API.

Obviously this isn't the fault of SkyLang for using a different forge, but this PR should probably be stripped to just the JSON entry and then held open (perhaps in Draft mode) until this project's tooling is fixed to accept other forges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants