Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(writer): fixd write == nil #31

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

banfushen
Copy link

@banfushen banfushen commented Jul 30, 2024

修复
Frame 1: /home/banfushen/NimoShake/nimo-shake/full-sync/document-syncer.go:51 (PC: 1038afc)
46: w := writer.NewWriter(conf.Options.TargetType, conf.Options.TargetAddress, ns, conf.Options.LogLevel)
47: if w == nil {
48: LOG.Crashf("tableSyncer[%v] documentSyncer[%v] create writer failed", tableSyncerId, table)
49: }
50:
=> 51: w.PassTableDesc(tableDescribe)
52:
53: return &documentSyncer{
54: tableSyncerId: tableSyncerId,
55: id: id,
56: inputChan: inputChan,
(dlv) print w
nimo-shake/writer.Writer(*nimo-shake/writer.MongoCommunityWriter) nil
(dlv) print w == nil
false

writer == nil 无法正确判断

@CLAassistant
Copy link

CLAassistant commented Jul 30, 2024

CLA assistant check
All committers have signed the CLA.

@banfushen banfushen closed this Jul 30, 2024
@banfushen banfushen reopened this Jul 30, 2024
@banfushen banfushen closed this Jul 30, 2024
@banfushen banfushen reopened this Jul 30, 2024
@banfushen banfushen changed the title fix(writer): fixd interface{} == nil fix(writer): fixd write == nil Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants