Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduction of support to TTML #15

Draft
wants to merge 464 commits into
base: develop
Choose a base branch
from
Draft

Introduction of support to TTML #15

wants to merge 464 commits into from
+8,675 −714

Conversation

alexandercerutti
Copy link
Owner

@alexandercerutti alexandercerutti commented Feb 18, 2024 •
edited
Loading

Breaking changes

  • (Re)Introduced Entities.Style;
  • Removed Entities.Tag.setStyles;
  • Removed the concepts of offset and length in lines;
  • (Behavior) Adapters now are in charge of specifing the entities to apply to specific cues, in a ordered way (captions-renderer won't re-order them anymore)

Todo list

  • Add meaningful error classes instead of generic throw new Error()

@alexandercerutti
Improved loop with continue
58c1d3e
@alexandercerutti
Fixed parseCue creation of useless cueNodes by checking if they are e…
1e57775 
…mpty first
@alexandercerutti
Removed offset and length from entities, entity leafability, refactor…
437cd96 
…ed orchestrator and cueNode entities sorting
@alexandercerutti
Changed tests for IntervalBinaryTree
9951ee1
@alexandercerutti
Removed offset and length from entities specs
940da4c
@alexandercerutti
Decoupled styles from Entities' TagType
ff960ed
@alexandercerutti
Splitted Style Entities from Tag Entities
68bef33
@alexandercerutti
Set Webvtt adapter to generate style entities for global, id instead …
5af77ae 
…of attaching them to a tag entity
@alexandercerutti
Removed attribute style from Tag Entity and fixed tests
e261a52
@alexandercerutti
Removed GenericEntity, converted tag and style entities to functions …
8093eed 
…that return objects
@alexandercerutti
Fixed tests with new functions for entities
7ca4d76
@alexandercerutti
Refactored entitiesToDOM to support style entities
ed0f007
@alexandercerutti
Changed getSubtreeFromCueNodes to render same styles also on new lines (
3c81a4e 
#11)
@alexandercerutti
Improved type notation for commitDOMTree
24a8014
@alexandercerutti
Changed Entities test
5882c92
@alexandercerutti
Added readonly modifies to StyleEntity
c8ceeb5
@alexandercerutti
Improved Playwright test through RendererFixture
8442143
@alexandercerutti
Moved playwright test navigation to RendererFixture
021c50b
@alexandercerutti
Added new test to check for text color
035051f
@alexandercerutti
Removed Voice and Lang tags as a shared supported tag and changed it …
9ed29d9 
…to be span
@alexandercerutti
Added Webvtt tag entities override to match with styles but send cue …
ae1db97 
…as span if tag is not among supported ones
@alexandercerutti
Fixed more parsing tests
21dcf96
@alexandercerutti
Removed satisfies for TS 5.x as not yet upgraded
bfb4b14
@alexandercerutti
Fixed more parser tests after changes
312ed46
@alexandercerutti
Merge branch 'feature/entities-rework' into feature/ttml-adapter
e72d0a3
@alexandercerutti
Improve timeContext proxy comments and names and added comment for Sc…
31af1ac 
…ope mental model
@alexandercerutti
Fixed scope test execution, which was creating another scope in the c…
4c62953 
…hain and expecting them to be read as a children
@alexandercerutti
Changed to package-lock
4f3ac58
@alexandercerutti
Changed sample to accept ttml tracks
7e01ca8
@alexandercerutti
Upgraded Vite@^5
4fc3001
@alexandercerutti
Added DestinationFactory type
f270a37
@alexandercerutti
Improved readability of RepresentationTree
9f05c68
@alexandercerutti
Removed idref parameter from createStyleParser's executor
ce69af6
@alexandercerutti
Removed styleParser from createRegionParser as unused (moved internal…
0fb2a8c 
… to the function
@alexandercerutti
Added storage as parameter for memoizationFactory
f81b591
@alexandercerutti
Moved scope contexts merging to happen through a symbol (hook)
74b424c
@alexandercerutti
Added onAttachedSymbol and args getter to retrieve the arguments the …
791b6d8 
…context has been called with
@alexandercerutti
Set StyleContainerContext to process styles as containers as soon as …
de1e3a8 
…the context is attached, with IDRefs conflict resolution;

Removed registeredStyles accessor and reworked merge implementation
@alexandercerutti
Removed style parser early cache creation and style attributes extrac…
a1a0b1d 
…tion as now moved to StyleContainerContext
@alexandercerutti
Added link in StyleContainerContext
dcb1286
@alexandercerutti
Moved chained referencial style resolution to style container context
0b19c5a
@alexandercerutti
Added forgotten extensions and improved import type
1dc51b4
@alexandercerutti
Added now mandatory scope to createRegionParser
1fa88d1
@alexandercerutti
Removed unused StyleContainerContext styles property
8ead8c7
@alexandercerutti
Removed unused property styleParserGetterSymbol
8f966b6
@alexandercerutti
Added looking for inherited styles in parent as well
d3aa4c5
@alexandercerutti
Commented unused Tokenizer functions
4b1589c
@alexandercerutti
Added attaching event on addContext
d7b818f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexandercerutti alexandercerutti

Labels
💥 Breaking Change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multi line does not preserve style
1 participant
@alexandercerutti