Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix orchestratord helm chart resources #9

Closed
wants to merge 1 commit into from

Conversation

alex-hunt-materialize
Copy link
Owner

Fixes orchestratord helm chart resources specification.

  1. Memory requests should always be equal to limits, as memory can generally not be reduced without killing the pod.
  2. Limiting CPU is usually not useful, and prevents us from spiking briefly in periods of extremely rare load.
  3. The indentation when templating the resources was a bit too deep.

Motivation

Part of https://github.com/MaterializeInc/cloud/issues/10285

Tips for reviewer

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant