Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sqlalchemy connection pool problems #24

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

jemrobinson
Copy link
Member

  • Call all() on SQLAlchemy queries before returning them to avoid connection leaks

Closes #23

…s dangling queries which unnecessarily use up connections from the pool.
Copy link

github-actions bot commented Jan 9, 2025

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  guacamole_user_sync/postgresql
  postgresql_backend.py
Project Total  

This report was generated by python-coverage-comment-action

@jemrobinson jemrobinson merged commit 958eb0d into main Jan 9, 2025
1 check passed
@jemrobinson jemrobinson deleted the 23-fix-sqlalchemy-connection-pool-problems branch January 9, 2025 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SQLAlchemy QueuePool timeout
1 participant