Pr 14038 suggestion #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @akurmustafa -- I kicked off the PR checks on this PR ❤️ |
alamb
merged commit 88fbbf1
into
alamb:alamb/encapsulate_equiv_properties
13 of 14 checks passed
|
WHoops -- I see this targeted a different branch #26 -- reopening |
|
apache#14038 (comment) -- pushed to 14038 Sorry about that |
|
BTW making collapse_lex_req will definitely help
But I think there is more potential benefit to avoiding having to re-normalize as much. |
alamb
added a commit
to apache/datafusion
that referenced
this pull request
Jan 10, 2025
…id clone (#14038) * Move collapse_lex_ordering to Lexordering::collapse * reduce diff * avoid clone, cleanup * Introduce LexRequirement::collapse * Improve performance of collapse, from @akurmustafa alamb#26 fix formatting * Revert "Improve performance of collapse, from @akurmustafa" This reverts commit a44acfd. * remove incorrect comment --------- Co-authored-by: Mustafa Akur <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
What changes are included in this PR?
As discussed in the #13748, implementation of the
collapsemight be one of the reasons of the slow performance when column number is very large. This PR changes thecollapseimplementation to remove quadratic complexity.I couldn't verify, however updated implementation might remedy some part of the problem.
Are these changes tested?
Are there any user-facing changes?