Skip to content

Commit

Permalink
Clarify leaving PRs open
Browse files Browse the repository at this point in the history
  • Loading branch information
alamb committed May 17, 2024
1 parent 3d95a03 commit 9e95d64
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion docs/source/contributor-guide/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ The lifecycle of a PR is:
1. Create a PR targeting the `main` branch.
2. For returning contributors, CI tests are automatically run. For new contributors a committer must first trigger the tests.
3. Your PR will be reviewed. Please respond to all feedback on the PR: you don't have to change the code, but you should acknowledge the feedback.
4. Once the PR is approved, one of the [committers] will merge your PR, typically within 24 hours. We leave approved PRs open for some time to allow for additional feedback from the community.
4. Once the PR is approved, one of the [committers] will merge your PR, typically within 24 hours. We leave approved "major" changes (see below) open for 24 hours prior to merging, and sometimes leave "minor" PRs open for the same time to permit additional feedback.

[committers]: https://people.apache.org/phonebook.html?unix=datafusion

Expand Down

0 comments on commit 9e95d64

Please sign in to comment.