fix(k8s-metacollector/tests): update tests to reflect latest changes

Signed-off-by: Aldo Lacuku <[email protected]>
alacuku · Jan 2, 2024 · 6369df8 · 6369df8
1 parent 6dbdad4
commit 6369df8
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 6 deletions.
diff --git a/charts/k8s-metacollector/tests/unit/chartInfo.go b/charts/k8s-metacollector/tests/unit/chartInfo.go
@@ -6,13 +6,13 @@ import (
 	"testing"
 )
 
-func chartInfo(t *testing.T, chartPath string) (map[string]string, error) {
+func chartInfo(t *testing.T, chartPath string) (map[string]interface{}, error) {
 	// Get chart info.
 	output, err := helm.RunHelmCommandAndGetOutputE(t, &helm.Options{}, "show", "chart", chartPath)
 	if err != nil {
 		return nil, err
 	}
-	chartInfo := map[string]string{}
+	chartInfo := map[string]interface{}{}
 	err = yaml.Unmarshal([]byte(output), &chartInfo)
 	return chartInfo, err
 }
diff --git a/charts/k8s-metacollector/tests/unit/commonMetaFields_test.go b/charts/k8s-metacollector/tests/unit/commonMetaFields_test.go
@@ -170,17 +170,19 @@ func (s *commonMetaFieldsTest) TestLabels() {
 	// Get app version.
 	appVersion, found := cInfo["appVersion"]
 	s.True(found, "should find app version in chart info")
+	appVersion = appVersion.(string)
 	// Get chart version.
 	chartVersion, found := cInfo["version"]
 	s.True(found, "should find chart version in chart info")
 	// Get chart name.
 	chartName, found := cInfo["name"]
 	s.True(found, "should find chart name in chart info")
+	chartName = chartName.(string)
 	expectedLabels := map[string]string{
 		"helm.sh/chart":                fmt.Sprintf("%s-%s", chartName, chartVersion),
-		"app.kubernetes.io/name":       chartName,
+		"app.kubernetes.io/name":       chartName.(string),
 		"app.kubernetes.io/instance":   s.releaseName,
-		"app.kubernetes.io/version":    appVersion,
+		"app.kubernetes.io/version":    appVersion.(string),
 		"app.kubernetes.io/managed-by": "Helm",
 		"app.kubernetes.io/component":  "metadata-collector",
 	}

diff --git a/charts/k8s-metacollector/tests/unit/deploymentTemplate_test.go b/charts/k8s-metacollector/tests/unit/deploymentTemplate_test.go
@@ -67,14 +67,14 @@ func (s *deploymentTemplateTest) TestImage() {
 			map[string]string{
 				"image.repository": "falcosecurity/testingRepository",
 			},
-			"docker.io/falcosecurity/testingRepository:0.0.0",
+			fmt.Sprintf("docker.io/falcosecurity/testingRepository:%s", appVersion),
 		},
 		{
 			"changingImageRegistry",
 			map[string]string{
 				"image.registry": "ghcr.io",
 			},
-			"ghcr.io/falcosecurity/k8s-metacollector:0.0.0",
+			fmt.Sprintf("ghcr.io/falcosecurity/k8s-metacollector:%s", appVersion),
 		},
 		{
 			"changingAllImageFields",