Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review Updates: Dependency Fixes, Tests, and Code Cleanup #4

Merged
merged 9 commits into from
Jan 15, 2025

Conversation

L33tl
Copy link
Contributor

@L33tl L33tl commented Jan 9, 2025

Summary

Fix library versions, add tests and docstrings, and refactor duplicated code into a utils module.

Key Features

Updates

  • Library Versioning: Locked library versions to ensure consistent builds and prevent dependency-related issues.
  • Testing: Added comprehensive test coverage to validate existing functionality and changes.
  • Documentation: Included detailed docstrings for better code clarity and maintainability.
  • Code Refactoring: Moved duplicated code into a reusable utils module, improving code organization and reducing redundancy.

Краткое описание

Зафиксированы версии библиотек, добавлены тесты и докстринги, а также вынесен дублирующий код в модуль utils.

Основные изменения

Обновления

  • Фиксация версий библиотек: Зафиксированы версии зависимостей для обеспечения стабильных сборок и предотвращения конфликтов.
  • Тестирование: Добавлено покрытие тестами для проверки существующего функционала и новых изменений.
  • Документация: Добавлены подробные докстринги для улучшения читаемости и сопровождения кода.
  • Рефакторинг кода: Дублирующий код перенесён в модуль utils, что упрощает структуру и уменьшает избыточность.

L33tl and others added 2 commits January 15, 2025 15:48
…searchindex.js

utils:
  check_num_type to validate_number

check_tools:
  check_num_type to check_tools_verify_number

tools:
  check_num_type to tools_check_number
Refactoring: renamed method in utils and method wrappers
@zaleksandrne zaleksandrne self-requested a review January 15, 2025 13:46
@Vl-Tershch Vl-Tershch merged commit 9cb5794 into aimclub:master Jan 15, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants