Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scheduling order of nodes in topological scheduler #64

Merged
merged 8 commits into from
Nov 11, 2023

Conversation

Timotshak
Copy link
Collaborator

This is necessary to prevent lag optimised nodes from being scheduling several times

@Timotshak Timotshak requested a review from StannisMod November 9, 2023 17:20
@Timotshak Timotshak added the refactor The rewriting of existing code to improve code quality label Nov 9, 2023
@Timotshak Timotshak requested a review from vanoha November 9, 2023 17:21
Copy link
Collaborator

@StannisMod StannisMod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cosmetic

sampo/scheduler/topological/base.py Outdated Show resolved Hide resolved
sampo/scheduler/topological/base.py Outdated Show resolved Hide resolved
sampo/scheduler/topological/base.py Outdated Show resolved Hide resolved
sampo/scheduler/topological/base.py Outdated Show resolved Hide resolved
@Timotshak Timotshak closed this Nov 10, 2023
@Timotshak Timotshak reopened this Nov 10, 2023
@Timotshak Timotshak requested a review from StannisMod November 10, 2023 17:04
@StannisMod StannisMod added the bug Something isn't working label Nov 10, 2023
Copy link
Collaborator

@StannisMod StannisMod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@Timotshak Timotshak merged commit 64809c2 into main Nov 11, 2023
1 check passed
@StannisMod StannisMod deleted the fix/topological_scheduler branch January 23, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working refactor The rewriting of existing code to improve code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants