Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix synthetic generation and add comments to genetic operators with numpy #59

Merged
merged 18 commits into from
Oct 27, 2023

Conversation

Timotshak
Copy link
Collaborator

  • Use a deque instead of a list in graph_node_operations.py

  • Add comments to mutation scheduling order operator

# Conflicts:
#	pyproject.toml
The generator created graphs that had nodes, in addition
to the final one, that did not have children. Now it is
fixed.
 - Delete update_resource_borders_to_peak_values
   operator, because it can change chromosome such that
   corresponding schedule changes too, in cases when lag
   optimization is used.

 - Update scheduling order mutation operator. Now
   it uses in addition to information about node parents,
   information about children. New operator improves the
   performance of GA.
# Conflicts:
#	sampo/scheduler/genetic/operators.py
#	sampo/scheduler/genetic/schedule_builder.py
@Timotshak Timotshak added the refactor The rewriting of existing code to improve code quality label Oct 24, 2023
@Timotshak Timotshak requested a review from StannisMod October 24, 2023 17:39
@Timotshak Timotshak closed this Oct 24, 2023
@Timotshak Timotshak reopened this Oct 24, 2023
@Timotshak Timotshak closed this Oct 25, 2023
@Timotshak Timotshak reopened this Oct 25, 2023
@Timotshak Timotshak closed this Oct 25, 2023
@Timotshak Timotshak reopened this Oct 25, 2023
@Timotshak Timotshak changed the title Fix count_ancestors function in synthetic generation Fix synthetic generation Oct 25, 2023
@Timotshak Timotshak requested a review from vanoha October 25, 2023 15:07
Copy link
Collaborator

@StannisMod StannisMod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be comments near all complex numpy calls

and add comments to genetic operators with numpy
@Timotshak Timotshak closed this Oct 26, 2023
@Timotshak Timotshak reopened this Oct 26, 2023
@Timotshak Timotshak requested a review from StannisMod October 26, 2023 13:49
Copy link
Collaborator

@StannisMod StannisMod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@Timotshak Timotshak changed the title Fix synthetic generation Fix synthetic generation and add comments to genetic operators with numpy Oct 27, 2023
@Timotshak Timotshak merged commit cd7a1e8 into main Oct 27, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor The rewriting of existing code to improve code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants