-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix synthetic generation and add comments to genetic operators with numpy #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # pyproject.toml
The generator created graphs that had nodes, in addition to the final one, that did not have children. Now it is fixed.
- Delete update_resource_borders_to_peak_values operator, because it can change chromosome such that corresponding schedule changes too, in cases when lag optimization is used. - Update scheduling order mutation operator. Now it uses in addition to information about node parents, information about children. New operator improves the performance of GA.
# Conflicts: # sampo/scheduler/genetic/operators.py # sampo/scheduler/genetic/schedule_builder.py
Timotshak
added
the
refactor
The rewriting of existing code to improve code quality
label
Oct 24, 2023
… refactor/genetic_algorithm
Timotshak
changed the title
Fix count_ancestors function in synthetic generation
Fix synthetic generation
Oct 25, 2023
StannisMod
requested changes
Oct 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should be comments near all complex numpy calls
and add comments to genetic operators with numpy
StannisMod
approved these changes
Oct 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
Timotshak
changed the title
Fix synthetic generation
Fix synthetic generation and add comments to genetic operators with numpy
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a deque instead of a list in graph_node_operations.py
Add comments to mutation scheduling order operator