-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parallel SGS, zone fixes #55
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now we are ready to make pre-release version of zone planning
# Conflicts: # sampo/schemas/requirements.py
# Conflicts: # pyproject.toml # sampo/scheduler/timeline/zone_timeline.py
# Conflicts: # sampo/scheduler/genetic/operators.py # sampo/scheduler/genetic/schedule_builder.py # tests/scheduler/genetic/fixtures.py
# Conflicts: # sampo/scheduler/timeline/just_in_time_timeline.py # sampo/scheduler/timeline/momentum_timeline.py
…re/parallel_sgs # Conflicts: # sampo/scheduler/timeline/zone_timeline.py
# Conflicts: # pyproject.toml # sampo/scheduler/generic.py # sampo/scheduler/genetic/converter.py # sampo/scheduler/genetic/operators.py # sampo/scheduler/timeline/just_in_time_timeline.py # sampo/scheduler/timeline/momentum_timeline.py # sampo/scheduler/timeline/zone_timeline.py # sampo/scheduler/utils/local_optimization.py # sampo/schemas/zones.py # tests/scheduler/genetic/converter_test.py # tests/scheduler/timeline/just_in_time_timeline_test.py # tests/scheduler/timeline/momentum_timeline_test.py # tests/scheduler/timeline/zone_timeline_test.py
Parallel SGS leads performance issues in general situation (planning without zones). |
# Conflicts: # sampo/scheduler/genetic/operators.py # sampo/scheduler/genetic/schedule_builder.py # tests/scheduler/genetic/converter_test.py
vanoha
reviewed
Oct 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Request changes
vanoha
approved these changes
Oct 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced Genetic's
Serial SGS
withParallel SGS
can_schedule_at_the_moment
method to all timelinesZoneTimeline
with the ability to handle non-zero status change costsGeneralTimeline
to handle abstract objects in timeLinkedList
data structure with iterators to handle remove-on-iteration operationsParallel SGS is much more applicable to handle many constraints than Serial SGS because it depends on constraints checking method, not on find minimum satisfaction time.
In SAMPO we have renewable and non-renewable resources and zones, so it's true for us :)