Preliminary changes for release (WIP) #107
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @Roman223! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:
|
Roman223
commented
Mar 29, 2024
| has_logit=self.has_logit, | ||
| use_mixture=self.use_mixture, | ||
| classifier=None, | ||
| regressor=None, | ||
| ) | ||
|
|
||
| self.set_nodes(nodes=builder.skeleton["V"]) | ||
| self.set_nodes(nodes=edges_builder.vertices) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checkers policy
As mentioned in the #33, more structured way for checks should be made, namely, string-base constants should be replaced with enumerators and special objects for checking should be implemeneted.
Details
Checkers inherit logic of BAMT's learning, thus there are 2 types of checkers for nodes:
RawNodeCheckerandNodeChecker. The former is used for nodes in graphs (so for nodes without any attributes), the latter is considering the structure (so has almost entire bamt's typing).During learning RawNodeChecker is evolving into NodeChecker as well as default node types (Gaussian and Discrete) are evolving into final node types (Conditionals, Logit etc.)
Builders
Structure of builder was changed in order to prevent double-call of objects in
builder_base. Because of this also useless variables (i.e. `skeleton') was removed.