Downgrade minimum traitlets version to 5.4 #629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As we learned in aiidalab/aiidalab-docker-stack#494, it is really not good if traitlets dependency is installed outside of the conda enviroment (i.e. to ~/.local) as it may break the jupyter notebook. Here we downgrade the minimum traitlets version back to 5.4. (NOTE: That the original motivation to upgrading to 5.9 was performance, I believe it is better if we upgrade directly in the image).
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #629 +/- ##
=======================================
Coverage 83.61% 83.61%
=======================================
Files 16 16
Lines 3522 3522
=======================================
Hits 2945 2945
Misses 577 577
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
|
Notebook failures are unrelated to this PR. |
|
@edan-bainglass does this change make sense to you? |
edan-bainglass
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #621 I've unpinned traitlets dependency from
traitlets==5.9.0totraitlets~=5.9. What I did not realize, and we found out the hard way in aiidalab/aiidalab-docker-stack#494,traitlets>=5.10break the jupyter notebook version in the current AiiDAlab image.As aiidalab/aiidalab-docker-stack#494 showed as, it is really not good if traitlets dependency is installed outside of the conda enviroment (i.e. to ~/.local) as it may break the jupyter notebook. Here we downgrade the minimum traitlets version back to 5.4.
(NOTE: That the original motivation to upgrading to 5.9 was performance, I believe it is better if we upgrade directly in the image). I'll open a separate issue for discussion, this is just a hotfix.
Fixes aiidalab/aiidalab-docker-stack#494