Force space character encoding for canonical query parameters #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Force replacement space character as %20
isoos
reviewed
Jun 21, 2023
xvrh
reviewed
Jun 21, 2023
xvrh
approved these changes
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
I am facing some issues while trying to list objects in buckets hosted in CEPH S3
Using both
listObjectsandlistObjectsV2when nextMarker/nextContinuationToken contain spaces.Uri.encodeQueryComponentencodes spaces with+sign, while server encodes as%20which leads toSignatureDoesNotMatcherrorI've checked this signature calculation mismatch on vanilla AWS S3 and it can be reproduced with old
listObjectsmethod and objects with spaces in names