-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a mono package version of all apis #394
Conversation
@xvrh: Could you please check the total size of the files? IIRC pub.dev has a limit of 100MB, are we close to it? This will also mean that we'll have a better release story, but pub.dev is unlikely to generate dartdoc for it for now. Not that we need it necessarily, and we can also generate it ourselves and self-host it on github... |
@isoos the
-------------------------------------------------------------------------------
Language files blank comment code
-------------------------------------------------------------------------------
Dart 780 216113 745559 1519390 |
https://dart.dev/tools/pub/publishing :
So I think we are good on that front. |
Generated doc on my machine (20 core, 128GB memory):
|
There is also a size limit for those, any chance you haven't deleted it yet to measure it? |
|
IIRC 2GB uncompressed is the limit... |
@isoos if you still agree with my plan can you add package:aws_client to the publisher aws-dart.agilord.com? Also, can we use the (awesome) automated publishing from Github? That means we will have to add git tags the repository. Any recommendations on this? |
done.
The default is good for us I think (also I think it is the same as the one you've got in puppeteer's repo). |
Edit: We could add approval workflows, but I don't think it is necessary. |
Fixes #299
Create a tool
dart bin/generate.dart generate-single-package
that will copy all the APIs in a single package (aws_client
).Everything remains the same but we can now also publish a single package with all the APIs easily.
First commit are the changes in the generator, second commit the generated package.
Happy to discuss the idea more if needed.
If you agree with this change, then I will proceed to publish a new version of
aws_client
to pub.dev.