Skip to content

Commit

Permalink
Drop arm-unknown-linux-gnueabihf as precompiled target
Browse files Browse the repository at this point in the history
due to issues with the target-pointer-width (found 64, needed 32) and
hence a failing compilation

In order to fix cross-compilation
  • Loading branch information
paulgoetze committed Nov 26, 2023
1 parent f07bf1c commit 244a197
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 2 deletions.
3 changes: 2 additions & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ jobs:
matrix:
nif: ["2.16", "2.15"]
job:
- { target: arm-unknown-linux-gnueabihf , os: ubuntu-22.04 , use-cross: true }
- { target: aarch64-unknown-linux-gnu , os: ubuntu-22.04 , use-cross: true }
- { target: aarch64-unknown-linux-musl , os: ubuntu-22.04 , use-cross: true }
- { target: aarch64-apple-darwin , os: macos-11 }
Expand All @@ -40,12 +39,14 @@ jobs:
run: |
# Get the project version from mix.exs
echo "PROJECT_VERSION=$(sed -n 's/^ @version "\(.*\)"/\1/p' mix.exs | head -n1)" >> $GITHUB_ENV
- name: Install Rust toolchain
uses: dtolnay/rust-toolchain@stable
with:
toolchain: stable
target: ${{ matrix.job.target }}


- name: Build the project
id: build-crate
uses: philss/[email protected]
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ I.e. `mjml_nif 0.x` versions use mrml versions `>= 0.1, < 1.0.0`, and `mjml_nif
- Use rustler_precompiled v0.7.0 + drop support for Elixir < v1.12
- Use Rust edition 2021
- Use rustler v0.30.0
- Drop arm-unknown-linux-gnueabihf as precompiled target

---

Expand Down
2 changes: 1 addition & 1 deletion native/mjml_nif/.cargo/config
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ rustflags = [
[target.arm-unknown-linux-gnueabihf]
linker = "arm-linux-gnueabihf-gcc"
rustflags = [
"-l", "dylib=atomic"
"-l", "dylib=atomic",
]

# See https://github.com/rust-lang/rust/issues/59302
Expand Down

0 comments on commit 244a197

Please sign in to comment.