-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dropzone S2 migration #3429
Open
aramos-adobe
wants to merge
10
commits into
aramos-adobe/css781-illustrated-message-s2-tokens
Choose a base branch
from
aramos-adobe/css782-dropzone-s2-migration
base: aramos-adobe/css781-illustrated-message-s2-tokens
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Dropzone S2 migration #3429
aramos-adobe
wants to merge
10
commits into
aramos-adobe/css781-illustrated-message-s2-tokens
from
aramos-adobe/css782-dropzone-s2-migration
+2,864
−1,175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b2b714d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
13 tasks
aramos-adobe
force-pushed
the
aramos-adobe/css781-illustrated-message-s2-tokens
branch
from
January 8, 2025 17:44
b244774
to
230c342
Compare
aramos-adobe
force-pushed
the
aramos-adobe/css782-dropzone-s2-migration
branch
from
January 9, 2025 15:20
70c8b73
to
b2b714d
Compare
aramos-adobe
force-pushed
the
aramos-adobe/css781-illustrated-message-s2-tokens
branch
2 times, most recently
from
January 9, 2025 16:57
5a2a335
to
27ac354
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dropzone S2 Migration
Since dropzone shares a lot of illustrated message's new content tokens (typography and spacing), tons of unused
--mods
were removed.New mods
--mod-drop-zone-content-height
Removed mods
--mod-drop-zone-body-color
--mod-drop-zone-body-font-family
--mod-drop-zone-body-font-style
--mod-drop-zone-body-font-weight
--mod-drop-zone-body-line-height
--mod-drop-zone-content-color
--mod-drop-zone-content-edge-to-text
--mod-drop-zone-content-font-size
--mod-drop-zone-heading-color
--mod-drop-zone-heading-font-family
--mod-drop-zone-heading-font-size
--mod-drop-zone-heading-font-style
--mod-drop-zone-heading-font-weight
--mod-drop-zone-heading-line-height
--mod-drop-zone-heading-to-body
--mod-drop-zone-illustration-to-heading
--mod-drop-zone-illustration-to-title
How and where has this been tested?
Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.
Validation steps
- [x] Filled reflects hover state
- [x] Filled & Dragged state reflects
replace
Regression testing
Validate:
Screenshots
To-do list