Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropzone S2 migration #3429

Open
wants to merge 10 commits into
base: aramos-adobe/css781-illustrated-message-s2-tokens
Choose a base branch
from

Conversation

aramos-adobe
Copy link
Collaborator

Dropzone S2 Migration

Since dropzone shares a lot of illustrated message's new content tokens (typography and spacing), tons of unused--mods were removed.

New mods

--mod-drop-zone-content-height

Removed mods

--mod-drop-zone-body-color
--mod-drop-zone-body-font-family
--mod-drop-zone-body-font-style
--mod-drop-zone-body-font-weight
--mod-drop-zone-body-line-height
--mod-drop-zone-content-color
--mod-drop-zone-content-edge-to-text
--mod-drop-zone-content-font-size
--mod-drop-zone-heading-color
--mod-drop-zone-heading-font-family
--mod-drop-zone-heading-font-size
--mod-drop-zone-heading-font-style
--mod-drop-zone-heading-font-weight
--mod-drop-zone-heading-line-height
--mod-drop-zone-heading-to-body
--mod-drop-zone-illustration-to-heading
--mod-drop-zone-illustration-to-title

How and where has this been tested?

Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.

Validation steps

  1. Open the dropzone component in storybook:
    - [x] Filled reflects hover state
    - [x] Filled & Dragged state reflects replace

Regression testing

Validate:

  1. The documentation pages for at least two other components are still loading, including:
  • The pages render correctly, are accessible, and are responsive.
  1. If components have been modified, VRTs have been run on this branch:
  • VRTs have been run and looked at.
  • Any VRT changes have been accepted (by reviewer and/or PR author), or there are no changes.

Screenshots

Screenshot 2024-12-04 at 4 30 58 PM Screenshot 2024-12-04 at 4 30 21 PM Screenshot 2024-12-04 at 4 30 16 PM

To-do list

  • I have read the contribution guidelines.
  • I have updated relevant storybook stories and templates.
  • I have tested these changes in Windows High Contrast mode.
  • If my change impacts other components, I have tested to make sure they don't break.
  • If my change impacts documentation, I have updated the documentation accordingly.
  • ✨ This pull request is ready to merge. ✨

@aramos-adobe aramos-adobe self-assigned this Dec 4, 2024
Copy link

changeset-bot bot commented Dec 4, 2024

🦋 Changeset detected

Latest commit: b2b714d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@spectrum-css/dropzone Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@aramos-adobe aramos-adobe force-pushed the aramos-adobe/css782-dropzone-s2-migration branch from 70c8b73 to b2b714d Compare January 9, 2025 15:20
@aramos-adobe aramos-adobe force-pushed the aramos-adobe/css781-illustrated-message-s2-tokens branch 2 times, most recently from 5a2a335 to 27ac354 Compare January 9, 2025 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant