Skip to content

Commit

Permalink
chore(coachmark): remove with/out shortcut from story titles;
Browse files Browse the repository at this point in the history
deduplicate args
  • Loading branch information
cdransf committed Jan 23, 2025
1 parent 390597b commit 0610784
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 6 deletions.
4 changes: 2 additions & 2 deletions components/coachmark/stories/coachmark.stories.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import packageJson from "../package.json";
import { CoachMarkGroup } from "./coachmark.test.js";
import {
CoachmarkMenuStatesTemplate,
CoachmarkMediaStatesTemplate,
CoachMarkMediaStateTemplates,
CoachmarkShortcutStatesTemplate,
} from "./template.js";

Expand Down Expand Up @@ -130,7 +130,7 @@ Standard.parameters = {
Standard.args = { image: "example-card-landscape.png" };

/** Images and media have a minimum height and can grow with the parent component. Fixed height media is constrained to a 4:3 aspect ratio by applying the spectrum-CoachMark-image-wrapper--fixedHeight class. */
export const MediaStates = CoachmarkMediaStatesTemplate.bind({});
export const MediaStates = CoachMarkMediaStateTemplates.bind({});
MediaStates.tags = ["!dev"];
MediaStates.args = {
imageSource: "example-card-portrait.png",
Expand Down
9 changes: 5 additions & 4 deletions components/coachmark/stories/template.js
Original file line number Diff line number Diff line change
Expand Up @@ -245,16 +245,17 @@ export const CoachmarkShortcutStatesTemplate = (args, context) =>
columnGap: "100px",
rowGap: "200px",
},

content: [
Container({
withBorder: false,
heading: "With shortcut, with action menu",
content: Template({ ...args, hasKeyboardShortcut: true, hasActionMenu: true }, context),
heading: "With action menu",
content: Template({ ...args, hasActionMenu: true }, context),
}),
Container({
withBorder: false,
heading: "With shortcut menu, without action menu",
content: Template({ ...args, hasKeyboardShortcut: true, hasActionMenu: false }, context),
heading: "Without action menu",
content: Template({ ...args, hasActionMenu: false }, context),
}),
],
});

0 comments on commit 0610784

Please sign in to comment.