fix RCTAEPMessagingModule getLatestMessage and getCachedMessages #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a sample app with new Arch enabled
* lifecycle initialisation * lifecycle implementation fixes
| @@ -84,7 +86,11 @@ public void getCachedMessages(final Promise promise) { | |||
|
|
|||
| @ReactMethod | |||
| public void getLatestMessage(final Promise promise) { | |||
| promise.resolve(this.latestMessage); | |||
| if (this.latestMessage != null) { | |||
| promise.resolve(RCTAEPMessagingUtil.convertToReadableMap(convertMessageToMap(this.latestMessage))); | |||
There was a problem hiding this comment.
Let's remove RCTAEPMessagingUtil. since we're using the "static import" for the method.
cacheung
approved these changes
Dec 9, 2024
|
If we merge this PR to new_arch branch, do we need to also release messaging when it merge to main branch? Or we can have the messaging code update in main, but release to the npm later? |
namArora3112
approved these changes
Dec 17, 2024
|
I don't think we need to merge this PR to new_arc anymore. The changes are already in the main branch. |
|
Already merged to the main branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prevent exceptions from being thrown when casting a HashMap to ReadableMap. I noticed that there are some additional files that were added due to branching from @namArora3112's ios fix branch. If its easier to merge, I can just cherry pick my changes from faa352c.
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: