Add places accuracy #220
Open
Add places accuracy #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge down from Main -> Staging
dsoffiantini
requested review from
sbenedicadb,
cacheung and
yangyansong-adbe
|
@dsoffiantini can you take a look why the CI is failing? |
praveek
reviewed
Jun 12, 2023
| **Example** | ||
|
|
||
| ```typescript | ||
| Places.setAccuracyAuthorization('fullAccuracy'); |
There was a problem hiding this comment.
Can you remove the first 2 examples on directly using string instead of constant?
praveek
reviewed
Jun 12, 2023
| ```typescript | ||
| Places.setAccuracyAuthorization('fullAccuracy'); | ||
| Places.setAccuracyAuthorization('reducedAccuracy'); | ||
| Places.setAccuracyAuthorization(PlacesAccuracy.Full); |
There was a problem hiding this comment.
The other constants are fully capitalized. FULL / REDUCED
praveek
reviewed
Jun 12, 2023
| @@ -78,6 +78,12 @@ const setAuthorizationStatus = () => { | |||
| console.log('Authorization status set'); | |||
| }; | |||
|
|
|||
| const setAccuracyAuthorization = () => { | |||
| Places.setAccuracyAuthorization('fullAccuracy'); | |||
There was a problem hiding this comment.
Use PlacesAccuracy.FULL instead of hardcoded string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds iOS method for setting Accuracy in Places
How Has This Been Tested?
New unit tests added + sample app updated
Types of changes
Checklist: