Terms and Conditions Component #889

barshat7 · 2023-09-26T06:46:56Z

Terms and Conditions Component

Terms and Conditions component

Terms and conditions: code formatting and readme

Terms and conditions tooltip

Terms and conditions review comments

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

I have signed the Adobe Open Source CLA.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes and the overall coverage did not decrease.
All unit tests pass on CircleCi.
I ran all tests locally and they pass.

adobe-bot · 2023-09-26T07:07:10Z

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	100	100	73

adobe-bot · 2023-09-26T07:07:10Z

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	92	100	100	73

adobe-bot · 2023-09-26T07:07:22Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
landmark-one-main	moderate
region	moderate

rismehta · 2023-09-26T09:02:24Z

...nts/form/termsandconditions/v1/termsandconditions/clientlibs/editor/js/termsandconditions.js

+(function($) {
+    "use strict";
+
+    var Utils = window.CQ.FormsCoreComponents.Utils.v1,


Please use the latest ES6 syntax like let, const etc

rismehta · 2023-09-26T09:04:43Z

ui.af.apps/src/main/content/jcr_root/apps/core/fd/components/form/links/v1/links/.content.xml

+    jcr:primaryType="cq:Component"
+    jcr:title="Adaptive Form Links (v1)"
+    sling:resourceSuperType="core/fd/components/form/checkboxgroup/v1/checkboxgroup"
+    componentGroup=".core-adaptiveform"/>


The component group for this should be hidden, I don't see any usage of this other than TNC

Also should we name this as toggleable link ?

rismehta · 2023-09-26T09:09:21Z

ui.af.apps/src/main/content/jcr_root/apps/core/fd/components/form/links/v1/links/links.html

+  ~ See the License for the specific language governing permissions and
+  ~ limitations under the License.
+  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~*/-->
+<sly data-sly-use.renderer="${'checkboxgroup.js'}"


Why do you need to copy paste the entire sightly, it should auto inherit from parent ? This will lead to maintenance hazard

rismehta

check comments

adobe-bot · 2023-09-26T11:10:57Z

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	100	100	73

adobe-bot · 2023-09-26T11:10:58Z

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	91	100	100	73

adobe-bot · 2023-09-26T11:11:09Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
landmark-one-main	moderate
region	moderate

codecov · 2023-09-26T12:08:07Z

Codecov Report

Merging #889 (b1e26ec) into dev (08189ee) will increase coverage by 0.08%.
The diff coverage is 92.85%.

@@             Coverage Diff              @@
##                dev     #889      +/-   ##
============================================
+ Coverage     80.16%   80.25%   +0.08%     
- Complexity      718      728      +10     
============================================
  Files            88       89       +1     
  Lines          2032     2046      +14     
  Branches        269      271       +2     
============================================
+ Hits           1629     1642      +13     
  Misses          254      254              
- Partials        149      150       +1

Files	Coverage Δ
...s/core/components/internal/form/FormConstants.java	`100.00% <ø> (ø)`
...nternal/models/v1/form/TermsAndConditionsImpl.java	`92.85% <92.85%> (ø)`

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

adobe-bot · 2023-09-26T12:57:25Z

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	93	100	100	73

adobe-bot · 2023-09-26T12:57:25Z

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	100	100	73

adobe-bot · 2023-09-26T12:57:36Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
landmark-one-main	moderate
region	moderate

rismehta

check comments

rismehta · 2023-09-28T11:17:28Z

...af-core/src/main/java/com/adobe/cq/forms/core/components/models/form/TermsAndConditions.java

+
+    String FD_TERMS_AND_CONDITIONS = "fd:tnc";
+
+    boolean isShowApprovalOption();


Please add java doc for all API's and also update package-info

adobe-bot · 2023-10-02T16:40:26Z

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	100	100	73

adobe-bot · 2023-10-02T16:40:26Z

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	88	100	100	73

adobe-bot · 2023-10-02T16:40:38Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
landmark-one-main	moderate
region	moderate

adobe-bot · 2023-10-03T06:29:00Z

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	100	100	73

adobe-bot · 2023-10-03T06:29:00Z

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	90	100	100	73

adobe-bot · 2023-10-03T06:29:12Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
landmark-one-main	moderate
region	moderate

adobe-bot · 2023-10-03T07:10:45Z

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	89	100	100	73

adobe-bot · 2023-10-03T07:10:45Z

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	100	100	73

adobe-bot · 2023-10-03T07:10:57Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
landmark-one-main	moderate
region	moderate

adobe-bot · 2023-10-03T12:19:40Z

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	100	100	73

adobe-bot · 2023-10-03T12:19:40Z

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	88	100	100	73

adobe-bot · 2023-10-03T12:19:53Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
landmark-one-main	moderate
region	moderate

adobe-bot · 2023-10-09T07:34:48Z

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	100	100	73

adobe-bot · 2023-10-09T07:34:48Z

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	91	100	100	73

adobe-bot · 2023-10-09T07:35:00Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
landmark-one-main	moderate
region	moderate

rismehta · 2023-10-09T09:01:38Z

...r_root/apps/core/fd/components/form/toggleablelink/v1/toggleablelink/_cq_dialog/.content.xml

+                                                                  fieldLabel="Link"
+                                                                  fieldDescription="Enter the link."
+                                                                  required="{Boolean}true"/>
+                                                                <enumNames


Can you implement the rich text which was recently added by @im-shiv, its missing here ? Please also add test cases for the same.

This is already done

aem-core-forms-components/ui.af.apps/src/main/content/jcr_root/apps/core/fd/components/form/toggleablelink/v1/toggleablelink/widget.html

Line 30 in 07e8c84

${checkboxgroup.enumNamesAsTextContent[itemList.index].value @ context = checkboxgroup.enumNamesAsTextContent[itemList.index].richText ? 'html' : 'text'}

rismehta

check comments

rismehta · 2023-10-09T09:04:33Z

...af-core/src/main/java/com/adobe/cq/forms/core/components/models/form/TermsAndConditions.java

+ * Defines the form {@code TermsAndConditions} Sling Model used for the
+ * {@code /apps/core/fd/components/form/termsandconditions/v1/termsandconditions} component.
+ *
+ * @since com.adobe.cq.forms.core.components.models.form 4.5.0


Can you update the package-info.java with 4.7.0 and update the same here, since new interface is added

adobe-bot · 2023-10-09T10:24:58Z

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	91	100	100	73

adobe-bot · 2023-10-09T10:24:58Z

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	100	100	73

adobe-bot · 2023-10-09T10:25:10Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
landmark-one-main	moderate
region	moderate

adobe-bot · 2023-10-09T11:03:56Z

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	100	100	73

adobe-bot · 2023-10-09T11:03:57Z

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	86	100	100	73

adobe-bot · 2023-10-09T11:04:10Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
landmark-one-main	moderate
region	moderate

rismehta · 2023-10-09T11:32:19Z

...n/content/jcr_root/apps/core/fd/components/form/toggleablelink/v1/toggleablelink/widget.html

+  ~ limitations under the License.
+  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~*/-->
+<template data-sly-template.widget="${ @ checkboxgroup }">
+  <div class="cmp-adaptiveform-checkboxgroup__widget ${checkboxgroup.orientation}" id="${widgetId}">


Why is this copy pasted ? Ideally, markup needs to be re-used from checkbox group right ?

rismehta

-1 for now

adobe-bot · 2023-10-09T12:22:41Z

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	91	100	100	73

adobe-bot · 2023-10-09T12:22:41Z

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	100	100	73

adobe-bot · 2023-10-09T12:22:52Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
landmark-one-main	moderate
region	moderate

Terms and Conditions Component Terms and Conditions Component Terms and Conditions component Terms and conditions: code formatting and readme Terms and conditions tooltip Terms and conditions review comments Terms and conditions review comments Terms and Conditions Test Case Fix Terms and Conditions added new tests Terms and Conditions review comments Terms and Conditions component

adobe-bot · 2023-10-09T14:38:22Z

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	100	100	73

adobe-bot · 2023-10-09T14:38:22Z

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	91	100	100	73

adobe-bot · 2023-10-09T14:38:34Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
landmark-one-main	moderate
region	moderate

* Terms and Conditions Terms and Conditions Component Terms and Conditions Component Terms and Conditions component Terms and conditions: code formatting and readme Terms and conditions tooltip Terms and conditions review comments Terms and conditions review comments Terms and Conditions Test Case Fix Terms and Conditions added new tests Terms and Conditions review comments Terms and Conditions component * Terms and Conditions * Terms and Conditions * Terms and conditions: Rich Text Support * Terms and conditions: bump model version --------- Co-authored-by: barshatr <[email protected]>

rismehta reviewed Sep 26, 2023

View reviewed changes

rismehta requested changes Sep 26, 2023

View reviewed changes

rismehta requested changes Sep 28, 2023

View reviewed changes

github-actions bot force-pushed the terms-and-conditions-feature_singlecommit branch from 97375b1 to 3ca93e5 Compare October 2, 2023 08:36

barshat7 force-pushed the terms-and-conditions-feature_singlecommit branch from c48c506 to 5673178 Compare October 3, 2023 06:08

barshat7 force-pushed the terms-and-conditions-feature_singlecommit branch from 5673178 to fa1bdc8 Compare October 9, 2023 06:52

rismehta reviewed Oct 9, 2023

View reviewed changes

rismehta requested changes Oct 9, 2023

View reviewed changes

barshatr added 5 commits October 9, 2023 14:17

Terms and Conditions

1530192

Terms and Conditions

822ffe3

Terms and conditions: Rich Text Support

7098d06

Terms and conditions: bump model version

b1e26ec

github-actions bot force-pushed the terms-and-conditions-feature_singlecommit branch from 6685b0c to b1e26ec Compare October 9, 2023 14:19

rismehta merged commit f46f89a into dev Oct 10, 2023
4 checks passed

rismehta deleted the terms-and-conditions-feature_singlecommit branch October 10, 2023 06:24


		String FD_TERMS_AND_CONDITIONS = "fd:tnc";

		boolean isShowApprovalOption();

Terms and Conditions Component #889

Terms and Conditions Component #889

Conversation

barshat7 commented Sep 26, 2023

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

adobe-bot commented Sep 26, 2023

Lighthouse scores (desktop)

adobe-bot commented Sep 26, 2023

Lighthouse scores (mobile)

adobe-bot commented Sep 26, 2023

Accessibility Violations Found

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rismehta left a comment

Choose a reason for hiding this comment

adobe-bot commented Sep 26, 2023

Lighthouse scores (desktop)

adobe-bot commented Sep 26, 2023

Lighthouse scores (mobile)

adobe-bot commented Sep 26, 2023

Accessibility Violations Found

codecov bot commented Sep 26, 2023 • edited Loading

Codecov Report

adobe-bot commented Sep 26, 2023

Lighthouse scores (mobile)

adobe-bot commented Sep 26, 2023

Lighthouse scores (desktop)

adobe-bot commented Sep 26, 2023

Accessibility Violations Found

rismehta left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

adobe-bot commented Oct 2, 2023

Lighthouse scores (desktop)

adobe-bot commented Oct 2, 2023

Lighthouse scores (mobile)

adobe-bot commented Oct 2, 2023

Accessibility Violations Found

adobe-bot commented Oct 3, 2023

Lighthouse scores (desktop)

adobe-bot commented Oct 3, 2023

Lighthouse scores (mobile)

adobe-bot commented Oct 3, 2023

Accessibility Violations Found

adobe-bot commented Oct 3, 2023

Lighthouse scores (mobile)

adobe-bot commented Oct 3, 2023

Lighthouse scores (desktop)

adobe-bot commented Oct 3, 2023

Accessibility Violations Found

adobe-bot commented Oct 3, 2023

Lighthouse scores (desktop)

adobe-bot commented Oct 3, 2023

Lighthouse scores (mobile)

adobe-bot commented Oct 3, 2023

Accessibility Violations Found

adobe-bot commented Oct 9, 2023

Lighthouse scores (desktop)

adobe-bot commented Oct 9, 2023

Lighthouse scores (mobile)

adobe-bot commented Oct 9, 2023

Accessibility Violations Found

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rismehta left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

adobe-bot commented Oct 9, 2023

Lighthouse scores (mobile)

adobe-bot commented Oct 9, 2023

Lighthouse scores (desktop)

adobe-bot commented Oct 9, 2023

codecov bot commented Sep 26, 2023 •

edited

Loading