Add dictionaryId to MdJSON export dataDictionary object

[dvonanderson]

Closing issues

closes #679
closes #705
closes #682

Pull Request

• Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
    - [ ] Docs have been added / updated (for bug fixes / features)

• What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
  Add dictionaryId to dataDictionary object in MdJSON export

• What is the current behavior? (You can also link to an open issue here)
  Export mdJSON function does not write dictionaryId #679

• What is the new behavior (if this is a feature change)?

"dataDictionary": [
 "responsibleParty": {
          "party": [{ "contactId": "f16524f3-6ad7-44fa-842a-ec5bf8cb2c95" }],
          "role": "pointOfContact"
        },
        "subject": ["dataDictionary"],
        "dictionaryId": "7e520389-7b0a-4552-ac3f-f5f1bc81c056"
      }
    ]

• Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

• no

[hmaier-fws]

@dvonanderson this still doesn't work. The dictionaryId is exported to the mdJSON. But, the dictionaryId from an imported mdJSON file is not beinig assigned to the internal mdEditor-Json object.

[dvonanderson]

@hmaier-fws pushed up some new commits and revised the PR statement please take a look

[hmaier-fws]

@dvonanderson there are still some problems.

Issue #679 seems to be resolved. But when importing mdJSON, the dataDictionary and contact arrays are still being embedded in the "type": "records" object (issue #682).

Import of mdJSON, still does not associate the dictionary with the metadata record (no dictionary selected under /record/xxx/edit/dictionary"). I assume this might be due to the dictionary records still not being structured properly. When viewing records using the mdEditor dashboard "Preview JSON":

• contacts are properly structured
• dictionaries should not enclose elements within a "dataDictionary" object. There should only be one object that contains all dictionary elements.

The dictionary is still structured as:

{
  "dataDictionary": {
    "citation": { },
    "subject": [ ],
    "responsibleParty": { },
    "entity": [ ],
    "domain": [ ],
    "description": " ",
    "dictionaryIncludedWithResource": false,
    "dictionaryId": "8dd05b0d-95c9-40f0-880d-72d18ef29c27"
  },
  "dictionaryId": "7648f752-1e09-4fdc-8cdd-c18d233f89bb"
}

It should be structured as follows:

{
  "citation": { },
  "subject": [ ],
  "responsibleParty": { },
  "entity": [ ],
  "domain": [ ],
  "description": " ",
  "dictionaryIncludedWithResource": false,
  "dictionaryId": "8dd05b0d-95c9-40f0-880d-72d18ef29c27"
}

On export, the mdDictionary array IS NOT using the identifiers from .dataDictionary.dictionaryId but it is generating a new .dictionaryId and using that instead of the identifier within the dataDictionary element.