add pluggable regex engine support #837
Open
+53
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sounds like a good idea! |
jasnell
reviewed
Jan 10, 2025
| std::optional<type> create_regex_instance(std::string_view pattern, | ||
| bool ignore_case); | ||
|
|
||
| std::optional<std::vector<std::string>> regex_search(std::string_view input, std::string_view pattern); |
There was a problem hiding this comment.
Overall this looks fine. I'm not entirely in love with the std::optional<std::vector<...>> part but can live with it.
|
Definite +1 on the idea. The only key requirement is that in practical use, it will be necessary for implementations using V8 to acquire the lock on the isolate if it doesn't have it already. Just worth keeping in mind when considering the overhead here. I would make sure that the API allows passing in a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal. Not meant to be merged as it is.
The goal is to have an abstract class under ada::url_pattern_regex::provider, where any application can implement their own class that inherits from this provider class. Later, we will use this abstract method class methods inside the URLPattern to enable Node.js like applications to not depend on std::regex.
By default, we will create a std_regex_provider class that inherits from provider to test our changes locally.
Any feedback is welcome.
cc @lemire @jasnell @mikea