Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] [Redux Toolkit Migration] queriesSlice #4016

Open
wants to merge 9 commits into
base: redux-toolkit-createSlice
Choose a base branch
from

Conversation

joel-jeremy
Copy link
Contributor

@joel-jeremy joel-jeremy commented Dec 19, 2024

  • actions/account.ts / reducers/account.ts -> accounts/accountsSlice.ts [Redux Toolkit Migration] accountsSlice #4012
  • actions/queries.ts / reducers/queries.ts -> queries/queriesSlice.ts [WIP] [Redux Toolkit Migration] queriesSlice #4016
  • actions/app.ts / reducers/app.ts -> app/appSlice.ts
  • actions/budgets.ts / reducers/budgets.ts -> budgets/budgetsSlice.ts
  • actions/modals.ts / reducers/modals.ts -> modals/modalsSlice.ts
  • actions/notifications.ts / reducers/notifications.ts -> notifications/notificationsSlice.ts
  • actions/prefs.ts / reducers/prefs.ts -> prefs/prefsSlice.ts
  • actions/user.ts / reducers/user.ts -> users/usersSlice.ts

@actual-github-bot actual-github-bot bot changed the title [Redux Toolkit Migration] Queries slice [WIP] [Redux Toolkit Migration] Queries slice Dec 19, 2024
Copy link

netlify bot commented Dec 19, 2024

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit 6c0c9ff
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/676496cc56b3260008194455
😎 Deploy Preview https://deploy-preview-4016.demo.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@joel-jeremy joel-jeremy changed the base branch from master to redux-toolkit-createSlice December 19, 2024 21:58
@joel-jeremy joel-jeremy changed the title [WIP] [Redux Toolkit Migration] Queries slice [WIP] [Redux Toolkit Migration] queriesSlice Dec 19, 2024
Copy link
Contributor

github-actions bot commented Dec 19, 2024

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
18 5.95 MB → 5.95 MB (+593 B) +0.01%
Changeset
File Δ Size
home/runner/work/actual/actual/packages/loot-core/src/client/queries/queriesSlice.ts 🆕 +12.81 kB 0 B → 12.81 kB
home/runner/work/actual/actual/packages/loot-core/src/client/undo.ts 🆕 +560 B 0 B → 560 B
home/runner/work/actual/actual/packages/loot-core/src/client/actions/modals.ts 📈 +403 B (+81.41%) 495 B → 898 B
src/components/budget/index.tsx 📈 +412 B (+4.41%) 9.13 kB → 9.53 kB
src/index.tsx 📈 +32 B (+3.89%) 823 B → 855 B
home/runner/work/actual/actual/packages/loot-core/src/client/store/index.ts 📈 +28 B (+2.74%) 1022 B → 1.03 kB
src/components/mobile/budget/index.tsx 📈 +320 B (+2.71%) 11.52 kB → 11.83 kB
src/components/sidebar/Account.tsx 📈 +134 B (+1.72%) 7.59 kB → 7.72 kB
src/components/modals/CloseAccountModal.tsx 📈 +188 B (+1.72%) 10.68 kB → 10.86 kB
src/components/modals/CreateLocalAccountModal.tsx 📈 +63 B (+0.86%) 7.17 kB → 7.23 kB
src/components/mobile/accounts/AccountTransactions.tsx 📈 +66 B (+0.86%) 7.53 kB → 7.59 kB
src/components/accounts/Account.tsx 📈 +138 B (+0.30%) 44.98 kB → 45.11 kB
src/components/modals/ImportTransactionsModal/ImportTransactionsModal.jsx 📈 +91 B (+0.30%) 30.07 kB → 30.16 kB
src/components/autocomplete/PayeeAutocomplete.tsx 📈 +33 B (+0.22%) 14.87 kB → 14.9 kB
src/components/reports/Overview.tsx 📈 +6 B (+0.04%) 14.79 kB → 14.8 kB
src/components/modals/EditRuleModal.jsx 📉 -16 B (-0.04%) 41.32 kB → 41.3 kB
home/runner/work/actual/actual/packages/loot-core/src/client/accounts/accountsSlice.ts 📉 -12 B (-0.23%) 5.12 kB → 5.11 kB
home/runner/work/actual/actual/packages/loot-core/src/client/reducers/index.ts 📉 -21 B (-12.88%) 163 B → 142 B
src/hooks/useUndo.ts 📉 -288 B (-24.64%) 1.14 kB → 881 B
home/runner/work/actual/actual/packages/loot-core/src/client/constants.ts 📉 -419 B (-35.18%) 1.16 kB → 772 B
home/runner/work/actual/actual/packages/loot-core/src/client/actions/queries.ts 🔥 -10.07 kB (-100%) 10.07 kB → 0 B
home/runner/work/actual/actual/packages/loot-core/src/client/reducers/queries.ts 🔥 -2.97 kB (-100%) 2.97 kB → 0 B
node_modules/throttleit/index.js 🔥 -889 B (-100%) 889 B → 0 B
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
static/js/narrow.js 84.31 kB → 84.68 kB (+386 B) +0.45%
static/js/wide.js 104.89 kB → 105.02 kB (+138 B) +0.13%
static/js/index.js 3.78 MB → 3.78 MB (+63 B) +0.00%
static/js/ReportRouter.js 1.58 MB → 1.58 MB (+6 B) +0.00%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
static/js/de.js 4.59 kB 0%
static/js/es.js 3.45 kB 0%
static/js/fr.js 12.6 kB 0%
static/js/pl.js 17 B 0%
static/js/ta.js 17 B 0%
static/js/indexeddb-main-thread-worker-e59fee74.js 13.5 kB 0%
static/js/zh-Hant.js 10.13 kB 0%
static/js/workbox-window.prod.es5.js 5.69 kB 0%
static/js/resize-observer.js 18.37 kB 0%
static/js/en.js 93.64 kB 0%
static/js/BackgroundImage.js 122.29 kB 0%
static/js/uk.js 120.7 kB 0%
static/js/useAccountPreviewTransactions.js 1.63 kB 0%
static/js/AppliedFilters.js 10.21 kB 0%

Copy link
Contributor

github-actions bot commented Dec 19, 2024

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
1 1.33 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.js 1.33 MB 0%

@joel-jeremy joel-jeremy force-pushed the redux-toolkit-createSlice branch from 9f560a7 to ed63667 Compare December 19, 2024 22:39
@joel-jeremy joel-jeremy force-pushed the redux-toolkit-queries-slice branch from 6c0c9ff to 23fbbd0 Compare December 19, 2024 22:40
@joel-jeremy joel-jeremy force-pushed the redux-toolkit-queries-slice branch 2 times, most recently from 373fa93 to a18db77 Compare December 20, 2024 17:29
Copy link
Contributor

👋 Hi! It looks like this PR has not had any changes for a week now. Would you like someone to review this PR? If so - please remove the "[WIP]" prefix from the PR title. That will let the community know that this PR is open for a review.

@github-actions github-actions bot added the Stale label Dec 28, 2024
@joel-jeremy joel-jeremy removed the Stale label Dec 31, 2024
@joel-jeremy joel-jeremy force-pushed the redux-toolkit-queries-slice branch from a18db77 to 0a7e38c Compare January 1, 2025 19:30
@joel-jeremy joel-jeremy force-pushed the redux-toolkit-createSlice branch from e8d550e to ace372d Compare January 6, 2025 18:30
@joel-jeremy joel-jeremy force-pushed the redux-toolkit-queries-slice branch from 0a7e38c to 9931e3e Compare January 6, 2025 18:31
@joel-jeremy joel-jeremy force-pushed the redux-toolkit-createSlice branch 3 times, most recently from 8d4efb2 to 7c128b1 Compare January 7, 2025 22:21
@joel-jeremy joel-jeremy force-pushed the redux-toolkit-queries-slice branch 2 times, most recently from 330129d to d332b25 Compare January 7, 2025 22:38
@joel-jeremy joel-jeremy force-pushed the redux-toolkit-createSlice branch from 432ab92 to 5ed4eb0 Compare January 8, 2025 07:34
@joel-jeremy joel-jeremy force-pushed the redux-toolkit-queries-slice branch 2 times, most recently from 1433260 to e1b59ad Compare January 8, 2025 07:56
@joel-jeremy joel-jeremy force-pushed the redux-toolkit-createSlice branch from f498538 to 968172c Compare January 8, 2025 08:14
@joel-jeremy joel-jeremy force-pushed the redux-toolkit-queries-slice branch from e1b59ad to 7c3dcba Compare January 8, 2025 08:15
@joel-jeremy joel-jeremy force-pushed the redux-toolkit-createSlice branch from 968172c to 377e06a Compare January 8, 2025 18:45
@joel-jeremy joel-jeremy force-pushed the redux-toolkit-queries-slice branch 3 times, most recently from db6331f to e8484c9 Compare January 9, 2025 09:02
@joel-jeremy joel-jeremy force-pushed the redux-toolkit-createSlice branch from 1fd660b to b23890b Compare January 10, 2025 17:16
@joel-jeremy joel-jeremy force-pushed the redux-toolkit-queries-slice branch from d6edc25 to ef37a83 Compare January 10, 2025 17:21
@joel-jeremy joel-jeremy force-pushed the redux-toolkit-createSlice branch from d6e4748 to e65926d Compare January 10, 2025 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant