Warning Color Consolidations

[carkom]

Consolidating and making more consistent the warning and upcoming colors.

[netlify]

✅ Deploy Preview for actualbudget ready!

Name	Link
🔨 Latest commit	499aac9
🔍 Latest deploy log	https://app.netlify.com/sites/actualbudget/deploys/6547beed649f1c0008a1f225
😎 Deploy Preview	https://deploy-preview-1798.demo.actualbudget.org/
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[github-actions]

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
16	2.83 MB → 2.83 MB (-722 B)	-0.02%

Changeset

File	Δ	Size
src/components/Notifications.tsx	📈 +36 B (+0.42%)	8.36 kB → 8.4 kB
src/components/DevelopmentTopBar.tsx	📈 +2 B (+0.16%)	1.2 kB → 1.2 kB
src/components/budget/MobileBudgetTable.js	📉 -4 B (-0.01%)	71 kB → 71 kB
src/components/transactions/MobileTransaction.js	📉 -4 B (-0.01%)	49.04 kB → 49.03 kB
src/components/transactions/TransactionsTable.js	📉 -11 B (-0.02%)	65.77 kB → 65.76 kB
src/components/budget/report/BudgetSummary.tsx	📉 -7 B (-0.04%)	18.58 kB → 18.57 kB
src/components/schedules/StatusBadge.tsx	📉 -2 B (-0.06%)	3.24 kB → 3.24 kB
src/style/themes/dark.ts	📉 -125 B (-1.14%)	10.75 kB → 10.62 kB
src/style/themes/development.ts	📉 -152 B (-1.46%)	10.15 kB → 10 kB
src/style/themes/light.ts	📉 -395 B (-3.45%)	11.19 kB → 10.8 kB
src/icons/v2/Eye.tsx	📉 -94 B (-3.84%)	2.39 kB → 2.3 kB

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

Asset	File Size	% Changed
static/js/main.js	1.12 MB → 1.12 MB (-700 B)	-0.06%
static/js/wide-components.chunk.js	126.69 kB → 126.67 kB (-18 B)	-0.01%
static/js/narrow-components.chunk.js	51.88 kB → 51.88 kB (-4 B)	-0.01%

Unchanged

Asset	File Size	% Changed
static/js/848.chunk.js	760.98 kB	0%
static/media/Inter-italic.var.woff2	239.29 kB	0%
static/media/Inter-roman.var.woff2	221.86 kB	0%
static/js/444.chunk.js	156.11 kB	0%
static/js/231.chunk.js	117.37 kB	0%
static/js/reports.chunk.js	29.97 kB	0%
static/js/473.chunk.js	13 kB	0%
static/js/312.chunk.js	12.78 kB	0%
static/js/resize-observer-polyfill.chunk.js	8.88 kB	0%
static/css/main.css	7.41 kB	0%
asset-manifest.json	2.07 kB	0%
index.html	1.66 kB	0%
static/media/browser-server.js	903 B	0%

[github-actions]

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
2	2.22 MB	0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
kcab.worker.js	1.23 MB	0%
xfo.xfo.kcab.worker.js	1014.46 kB	0%

[youngcw]

The warning notification seems harder to read now. Was that change intentional?

[carkom]

The warning notification seems harder to read now. Was that change intentional?

No, not intending to make anything harder to read...

I only changed any given warning text/background by one shade in either direction in order to try to normalize it across the app. But I can see that in the case you mention the background was one shade darker and the text was one shade lighter, decreasing contrast in both situations, this is not desirable. I've adjusted it a bit. Can you see if it's better? If not, how do you think we should change it? Darker text? Lighter background?

[carkom]

@youngcw, can you see if my changes work better? Cheers!

[youngcw]

Its better. I think I'll still defer to @MatissJanis since its a visual change

[MatissJanis]

👋 Sorry for the slow review.

Would you mind updating the VRT screenshots to make CI pass? The updated screenshots will make reviewing this a bit easier since I'll be able to catch most of the changes by just looking at the images instead of manually looking at them in the app.

[carkom]

👋 Sorry for the slow review.

Would you mind updating the VRT screenshots to make CI pass? The updated screenshots will make reviewing this a bit easier since I'll be able to catch most of the changes by just looking at the images instead of manually looking at them in the app.

Hey, I tried to update VRT screenshots a bunch of times but couldn't get it to work. Realized I wasn't getting any VRT errors on my local. Re-ran checks on github and they all passed. So this one is ready to go!

[MatissJanis]

The new yellow color blends too much with the background. What if we swapped it the other way around: make the darker tone the one we use instead of the faded?

before	after

[carkom]

The new yellow color blends too much with the background. What if we swapped it the other way around: make the darker tone the one we use instead of the faded?

I agree, seems off. I've adjusted the background back to the darker one and changed the text areas that were experiencing poor contrast issues. Have a look!

[MatissJanis]

LGTM!

[carkom]

Fixes #1870

[carkom]

Fixes #1869

[carkom]

Fixes #1807

[carkom]

Fixes #1806

[carkom]

Fixes #1805