Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form field label (cc0f0a) update rule #973

Merged
merged 87 commits into from
Feb 13, 2020
Merged

Conversation

Jym77
Copy link
Collaborator

@Jym77 Jym77 commented Oct 10, 2019

Update the form field labels rule. Hopefully fixing issues of previous versions…

Closes issues:

Reimplements PRs:

Need for Final Call:
This will require a 2 weeks Final Call


Pull Request Etiquette

When creating PR:

  • Make sure you requesting to pull a branch (right side) to the develop branch (left side).

After creating PR:

  • Add yourself (and co-authors) as "Assignees" for PR.
  • Add label to indicate if it's a Rule, Definition or Chore.
  • Close the issue that the PR resolves (and make sure the issue is referenced in the top of this comment)
  • Optionally request feedback from anyone in particular by assigning them as "Reviewers".

How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
  • Make sure to also review the proposed Final Call period. In case of disagreement, the longer period wins.

@Jym77 Jym77 added Rule Update Use this label for an existing rule that is being updated reviewers wanted labels Oct 10, 2019
@Jym77
Copy link
Collaborator Author

Jym77 commented Jan 30, 2020

Final Call ends on February 13th.

@Jym77 Jym77 added Review Call 1 week Call for review for small changes and removed reviewers wanted labels Jan 30, 2020
@Jym77
Copy link
Collaborator Author

Jym77 commented Feb 13, 2020

Final Call has ended. Merging.

@Jym77 Jym77 merged commit c0fe7af into develop Feb 13, 2020
@Jym77 Jym77 deleted the form-field-label-update-rule branch February 13, 2020 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review Call 1 week Call for review for small changes Rule Update Use this label for an existing rule that is being updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants