feat(datahub-client): additionally generates java8 artefacts #297
Conversation
|
Hello @sgomezvillamor 😄 Thank you so much for opening a pull request!
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
actionlint
[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:1:17: Double quote to prevent globbing and word splitting [shellcheck]
[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:1:17: Double quote to prevent globbing and word splitting [shellcheck]
[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:1:17: Double quote to prevent globbing and word splitting [shellcheck]
[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:1:17: Double quote to prevent globbing and word splitting [shellcheck]
| SIGNING_KEY: ${{ secrets.SIGNING_KEY }} | ||
| NEXUS_USERNAME: ${{ secrets.NEXUS_USERNAME }} | ||
| NEXUS_PASSWORD: ${{ secrets.NEXUS_PASSWORD }} | ||
| run: | |
There was a problem hiding this comment.
[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:1:17: Double quote to prevent globbing and word splitting [shellcheck]
| SIGNING_KEY: ${{ secrets.SIGNING_KEY }} | ||
| NEXUS_USERNAME: ${{ secrets.NEXUS_USERNAME }} | ||
| NEXUS_PASSWORD: ${{ secrets.NEXUS_PASSWORD }} | ||
| run: | |
There was a problem hiding this comment.
[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:1:17: Double quote to prevent globbing and word splitting [shellcheck]
There was a problem hiding this comment.
[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:2:48: Double quote to prevent globbing and word splitting [shellcheck]
There was a problem hiding this comment.
[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2001:style:2:7: See if you can use ${variable//search/replace} instead [shellcheck]
There was a problem hiding this comment.
[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:2:12: Double quote to prevent globbing and word splitting [shellcheck]
There was a problem hiding this comment.
[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:3:20: Double quote to prevent globbing and word splitting [shellcheck]
There was a problem hiding this comment.
[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:1:17: Double quote to prevent globbing and word splitting [shellcheck]
There was a problem hiding this comment.
[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:1:17: Double quote to prevent globbing and word splitting [shellcheck]
There was a problem hiding this comment.
[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:1:17: Double quote to prevent globbing and word splitting [shellcheck]
There was a problem hiding this comment.
[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:1:17: Double quote to prevent globbing and word splitting [shellcheck]
There was a problem hiding this comment.
[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:1:17: Double quote to prevent globbing and word splitting [shellcheck]
There was a problem hiding this comment.
[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:1:17: Double quote to prevent globbing and word splitting [shellcheck]
Codecov ReportAll modified and coverable lines are covered by tests ✅ Additional details and impacted files@@ Coverage Diff @@
## master #297 +/- ##
=============================================
+ Coverage 59.06% 63.61% +4.55%
+ Complexity 7235 2349 -4886
=============================================
Files 2021 153 -1868
Lines 128937 15945 -112992
Branches 5840 1547 -4293
=============================================
- Hits 76153 10144 -66009
+ Misses 50580 5113 -45467
+ Partials 2204 688 -1516 📢 Thoughts on this report? Let us know! |
|
Superseded by datahub-project#12106 |
Successfully tested locally
Checklist