Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: align global css vars + remove some legacy code #888

Merged
merged 10 commits into from
Oct 31, 2023
Merged

refactor: align global css vars + remove some legacy code #888

merged 10 commits into from
Oct 31, 2023

Conversation

dohaki
Copy link
Contributor

@dohaki dohaki commented Oct 30, 2023 •
edited
Loading

This PR refactors a few things:

  • Removes some legacy code
  • Aligns the global CSS vars for colors with the ones in Figma
  • Aligns the COLORS constant with above CSS vars
  • Refactors Text component to use above constant

The motivation here is to reduce the usage of hardcoded HEX colors throughout the codebase. I know that we always wanted to refactor this but as I started to work on the new UI updates, I was in need of something like this.

Closes ACX-1645

@vercel
Copy link

vercel bot commented Oct 30, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
frontend-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2023 10:44am
goerli-frontend-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2023 10:44am

@dohaki dohaki mentioned this pull request Oct 30, 2023
Merged
@linear
Copy link

linear bot commented Oct 30, 2023

ACX-1645 Refactor CSS vars

james-a-morris
james-a-morris approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@james-a-morris james-a-morris left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call. I was able to load this on my preview link and I don't notice anything broken. Is there a specific segment of this code that I could look at specifically that you want me to highlight in my review?

@dohaki dohaki merged commit 23c2680 into master Oct 31, 2023
6 checks passed
@dohaki dohaki deleted the refactor-css-vars branch October 31, 2023 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james-a-morris james-a-morris james-a-morris approved these changes

@amateima amateima Awaiting requested review from amateima

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dohaki @james-a-morris