improve: more effectively estimate suggested fees quote #887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
I've further explained in the PR |
ACX-1643 API/SDK: Reports of underpriced deposits
After changes deployed to the API yesterday, community relayers reported a sharp uptick in the number of unprofitable deposits. The RL relayer is filling most of these at (small) loss, per reporting from mydefi. Investigation indicates that the gas cost of the fill is being under-estimated by about 30k gas. Update: resolved - see comments for conclusions. |
james-a-morris
changed the title
james-a-morris
changed the title
pxrl
reviewed
Oct 27, 2023
pxrl
approved these changes
Oct 27, 2023
Whoops did not push the latest commit. Good eye. Note: all A/B testing was done with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We discovered a short circuit in the Vercel API's estimation of fee quotes.
This was causing a quote of roughly 80K gas units to make a fill.
The original recipient address being used on the FE is
0xBb23Cd0210F878Ea4CcA50e9dC307fb0Ed65Cf6B, which will incur a storage cost during the initial ERC20 transfer of 145,000 gas units. Properly passingrecipientAddressin the suggested-fees endpoint on prod will incur 120,000 gas units.In either case, we now default our recipient address to incur the storage cost of the ERC20 initializing a user's balance in the token.
Thus, the cost calculation will be preserved regardless of
recipientAddressbeing provided and using the Across UI will produce a more accurate gas estimation making it the cheaper alternative over aggregators.Closes: ACX-1643