Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(suggested-fees): Use dest provider for contract determination #884

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

pxrl
Copy link
Contributor

@pxrl pxrl commented Oct 26, 2023

No description provided.

@vercel
Copy link

vercel bot commented Oct 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
frontend-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 26, 2023 7:46pm
goerli-frontend-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 26, 2023 7:46pm

@@ -97,7 +98,7 @@ const handler = async (
}
const isRecipientAContract = await sdk.utils.isContractDeployedToAddress(
recipientAddress,
provider
getProvider(destinationChainId)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call. This is a subtle bug

@pxrl pxrl marked this pull request as ready for review October 26, 2023 20:09
@pxrl pxrl merged commit 1672213 into master Oct 26, 2023
6 checks passed
@pxrl pxrl deleted the pxrl/destProvider branch October 26, 2023 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants