-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve: simulate relay gas fees for messages #862
improve: simulate relay gas fees for messages #862
Conversation
ACX-1571 Estimate fill gas costs with non-empty message fields
For most cases, use the main RL relayer (0x428…) as the simulated EOA This only applies to situations where the |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ACX-1529 Avoid await on non-async functions. ACX-1575 Allow caller to pass optional custom EOA param
extra query parameter Note, this might produce situations where the caller gets a fee quote successfully but our relayers are not able to fill it. This should only be used if the caller knows that the ACX-1574 Return 4xx error if simulation reverts because of insufficient token balance or insufficient gas funds
This is important because we will never slow fill a deposit with a message, so we shouldn't be quoting these deposits. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a few comments!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, just some nits
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nicholaspai rerequested due to needing a UI change to accommodate the new request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but do we need to make changes to the relayer or let other callers of the API know before we merge and deploy?
We will require the following PR to be merged first: across-protocol/sdk#427
Fixes ACX-1529, ACX-1575, and ACX-1574