Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support per-chain fillDeadline env var #1363

Merged
merged 1 commit into from
Jan 9, 2025
Merged

support per-chain fillDeadline env var #1363

merged 1 commit into from
Jan 9, 2025

Conversation

gsteenkamp89
Copy link
Contributor

No description provided.

@vercel Vercel
Copy link

vercel bot commented Jan 9, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
app-frontend-v3 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 9, 2025 9:46am
sepolia-frontend-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 9, 2025 9:46am

@gsteenkamp89 gsteenkamp89 requested a review from pxrl January 9, 2025 09:24
dohaki
dohaki reviewed Jan 9, 2025
View reviewed changes
Copy link
Contributor

@dohaki dohaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 We should update the env var on Vercel before merging this one in so it directly builds with the new one

@gsteenkamp89
Copy link
Contributor Author

LGTM 👍 We should update the env var on Vercel before merging this one in so it directly builds with the new one

Done! I'll wait for the build, then we can merge this and promote it to production

@dohaki
Copy link
Contributor

dohaki commented Jan 9, 2025

I think you could just merge because once in master it needs to rebuild anyways

@gsteenkamp89 gsteenkamp89 merged commit d2f677b into master Jan 9, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dohaki dohaki dohaki approved these changes

@mrice32 mrice32 Awaiting requested review from mrice32 mrice32 is a code owner

@nicholaspai nicholaspai Awaiting requested review from nicholaspai nicholaspai is a code owner

@james-a-morris james-a-morris Awaiting requested review from james-a-morris james-a-morris is a code owner

@pxrl pxrl Awaiting requested review from pxrl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gsteenkamp89 @dohaki