script for comparing gas prices #1354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsteenkamp89
requested review from
mrice32,
nicholaspai,
dohaki and
james-a-morris
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
nicholaspai
reviewed
Jan 6, 2025
nicholaspai
reviewed
Jan 6, 2025
nicholaspai
previously approved these changes
Jan 6, 2025
james-a-morris
previously approved these changes
Jan 7, 2025
Comment on lines
+13
to
+20
| type Route = { | ||
| originChainId: number; | ||
| originToken: string; | ||
| destinationChainId: number; | ||
| destinationToken: string; | ||
| originTokenSymbol: string; | ||
| destinationTokenSymbol: string; | ||
| }; |
There was a problem hiding this comment.
fwiw I think we have this typing elsewhere as well. If not we definitely reference it in the src/ directory
There was a problem hiding this comment.
yeah ideally we can re-use a type
nicholaspai
previously approved these changes
Jan 10, 2025
## `stale-while-revalidate` We can reduce this cache time to 1s so that after the cached value is >1s old we can immediately start recomputing the limits value. This means in the best case we'll have as fresh gas cost data as possible. ## Gas price caching: We should ideally use less stale gas price data. However, we don't want to increase the /limits response time. We currently use the gas price to compute the gas cost so it makes sense to make the gas price cache time slightly longer or equal to the gas cost. This way if the gas cost cache is set, then we'll use the cached gas cost value. If its stale, then we'll fetch the gas price and hopefully hit the cache sometimes. This is why it doesn't make sense to set the gas price cache less than the gas cost cache time otherwise we'll very rarely hit the gas price cache.
…kenGasCost calculation Willl allow us to use more customized caching times for different gas cost components that are expected to change on different time periods
nicholaspai
previously approved these changes
Jan 13, 2025
james-a-morris
previously approved these changes
Jan 13, 2025
nicholaspai
dismissed stale reviews from james-a-morris and themself
via
2f4b20b
james-a-morris
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.