feat(svm): web3 v2, codama clients, and events retrieval #866
Conversation
Signed-off-by: Pablo Maldonado <[email protected]>
Signed-off-by: Pablo Maldonado <[email protected]>
Signed-off-by: Pablo Maldonado <[email protected]>
Signed-off-by: Pablo Maldonado <[email protected]>
Signed-off-by: Pablo Maldonado <[email protected]>
Signed-off-by: Pablo Maldonado <[email protected]>
md0x
requested review from
mrice32,
nicholaspai,
chrismaree,
Reinis-FRP,
pxrl and
bmzig
as code owners
Signed-off-by: Pablo Maldonado <[email protected]>
| codama = createFromRoot(rootNodeFromAnchor(MulticallHandlerIdl as AnchorIdl)); | ||
| codama.accept(renderJavaScriptVisitor(path.join(clientsPath, "MulticallHandler"))); | ||
|
|
||
| // codama = createFromRoot(rootNodeFromAnchor(MessageTransmitterIdl as AnchorIdl)); |
md0x
changed the title
md0x
changed the title
Signed-off-by: Pablo Maldonado <[email protected]>
| * Reads all events for a specific program. | ||
| */ | ||
| export async function readProgramEvents( | ||
| rpc: web3.Rpc<web3.SolanaRpcApiFromTransport<any>>, |
There was a problem hiding this comment.
maybe replace any with RpcTransport?
|
|
||
| type GetTransactionReturnType = ReturnType<GetTransactionApi["getTransaction"]>; | ||
|
|
||
| type GetSignaturesForAddressConfig = Readonly<{ |
There was a problem hiding this comment.
maybe can infer this type without replicating upstream:
type GetSignaturesForAddressConfig = Parameters<GetSignaturesForAddressApi["getSignaturesForAddress"]>[1]
| until?: Signature; | ||
| }>; | ||
|
|
||
| type GetSignaturesForAddressTransaction = { |
There was a problem hiding this comment.
maybe can also infer this:
type GetSignaturesForAddressTransaction = ReturnType<GetSignaturesForAddressApi["getSignaturesForAddress"]>[number];
| * Reads events from a transaction. | ||
| */ | ||
| export async function readEvents( | ||
| rpc: web3.Rpc<web3.SolanaRpcApiFromTransport<any>>, |
There was a problem hiding this comment.
maybe replace any with RpcTransport?
| const [pda] = await web3.getProgramDerivedAddress({ programAddress: programId, seeds: ["__event_authority"] }); | ||
| eventAuthorities.set(programId, pda); | ||
|
|
||
| const messageAccountKeys = txResult.transaction.message.accountKeys; |
There was a problem hiding this comment.
have you tested this with V0 transactions? does accountKeys also include loaded addresses from ALTs in web3-v2?
There was a problem hiding this comment.
this is pretty cool! I agree with @Reinis-FRP that we can be stricter on the typing but overall this makes sense: there are two distinct categories of web3 providers and we want to be able to support both so splitting by directory is reasonable
| /** | ||
| * Reads all events for a specific program. | ||
| */ | ||
| export async function readProgramEvents( |
Signed-off-by: Pablo Maldonado <[email protected]>
Signed-off-by: Pablo Maldonado <[email protected]>
| /** | ||
| * Reads all events for a specific program. | ||
| */ | ||
| export async function readProgramEventsV2( |
There was a problem hiding this comment.
Renamed to readProgramEventsV2 so they do not conflict with the v1 exports. I don't think this should be the final name as we want to prioritize V2 but for now I think it's fine until we start exposing this functions
| @@ -239,6 +239,8 @@ export function stringifyCpiEvent(obj: any): any { | |||
| return obj.toString(); | |||
| } else if (BN.isBN(obj)) { | |||
| return obj.toString(); | |||
| } else if (typeof obj === "bigint" && obj !== 0n) { | |||
There was a problem hiding this comment.
Big bad, i put that during some tests and forgot about it.
Thanks for catchinng!
Signed-off-by: Pablo Maldonado <[email protected]>
Changes proposed in this PR:
@solana/web3.jsv2 renamed as@solana/web3-v2.jsto support the previous version as wellCan be tested with: