Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(evm): L02 _destinationSettler Can Return Zero Address #834

Open
wants to merge 3 commits into
base: svm-dev
Choose a base branch
from
Open

fix(evm): L02 _destinationSettler Can Return Zero Address #834

wants to merge 3 commits into from

Conversation

mrice32
Copy link
Contributor

@mrice32 mrice32 commented Jan 6, 2025 •
edited by chrismaree
Loading

OZ identified the following issue:


Consider adding the requirement that the _destinationSettler value used in the FillInstruction struct of the resolved order cannot be the zero address.

This PR addresses this using the requested change.

@chrismaree chrismaree changed the base branch from master to svm-dev January 6, 2025 11:16
@chrismaree chrismaree changed the title fix: L02 _destinationSettler Can Return Zero Address fix(evm): L02 _destinationSettler Can Return Zero Address Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrismaree chrismaree chrismaree approved these changes

@nicholaspai nicholaspai Awaiting requested review from nicholaspai nicholaspai is a code owner

@pxrl pxrl Awaiting requested review from pxrl pxrl is a code owner

@bmzig bmzig Awaiting requested review from bmzig bmzig is a code owner

Assignees
No one assigned
Labels
OZ Audit - EVM December 2024
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrice32 @chrismaree