feat(svm): Refactor deposit ID to use big-endian encoding in Bytes32 format #810
+30
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pablo Maldonado <[email protected]>
Signed-off-by: Pablo Maldonado <[email protected]>
Signed-off-by: Pablo Maldonado <[email protected]>
Signed-off-by: Pablo Maldonado <[email protected]>
md0x
changed the title
Reinis-FRP
approved these changes
Dec 19, 2024
chrismaree
reviewed
Jan 8, 2025
| @@ -117,7 +117,7 @@ pub fn _deposit_v3( | |||
| // If the passed in deposit_id is all zeros, then we use the state's number of deposits as deposit_id. | |||
| if deposit_id == ZERO_DEPOSIT_ID { | |||
| state.number_of_deposits += 1; | |||
| applied_deposit_id[..4].copy_from_slice(&state.number_of_deposits.to_le_bytes()); | |||
| applied_deposit_id[28..].copy_from_slice(&state.number_of_deposits.to_be_bytes()); | |||
There was a problem hiding this comment.
this is great! I love how simple it is to get these structures to match what is expected here.
chrismaree
reviewed
Jan 8, 2025
| @@ -1,33 +1,16 @@ | |||
| import { BN } from "@coral-xyz/anchor"; | |||
| import { PublicKey } from "@solana/web3.js"; | |||
| import { ethers } from "ethers"; | |||
| import { BigNumber, ethers } from "ethers"; | |||
|
|
|||
| /** | |||
| * Converts an integer to a 32-byte Uint8Array. | |||
| */ | |||
| export function intToU8Array32(num: number | BN): number[] { | |||
There was a problem hiding this comment.
it might make sense at some point to have unit tests for these kinds of utils.
chrismaree
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
Motivation:
Previously, "safe" (
deposit_v3) deposit IDs were stored in little-endian (LE) format, causing friction for relayers and off-chain tools due to format conversions. Challenges included:Solution:
This PR stores "safe" (
deposit_v3) deposit IDs in BE format, storingnumber_of_depositsin the right-most bits. This aligns with EVM, simplifies cross-chain operations and reduces off-chain parsing complexityNote: The “unsafe” deposit (
unsafe_deposit_v3) does not require any changes and is unaffected by these challenges, as it uses a generated hash without endianness considerations.