Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: enable overriding the default cursor for an edge [#152] [#161] #173

Merged
merged 4 commits into from
Dec 29, 2020
Merged

fix: enable overriding the default cursor for an edge [#152] [#161] #173

merged 4 commits into from
Dec 29, 2020

Conversation

ronaldcurtis
Copy link
Contributor

@ronaldcurtis ronaldcurtis commented Dec 29, 2020 •
edited
Loading

This fixes #152 and #161 so that we are able to set custom cursors on edges.

As explained in #152, the reasons for why we may want to set and handle our own cursors are as follows:

  1. We could be interfacing with external services that use their own cursors, or don't paginate using offset/limit.
  2. Currently the cursors in this package just encode the OFFSET and OFFSET + LIMIT. But we may not want to use OFFSET in our SQL queries because it results in slow performance for large offsets.

@benwilson512 benwilson512 merged commit 6b8a334 into absinthe-graphql:master Dec 29, 2020
@benwilson512
Copy link
Contributor

hey @ronaldcurtis I think this is a good addition, thanks!

@SebastienGllmt SebastienGllmt mentioned this pull request Mar 15, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Overriding cursor throws warning
2 participants
@ronaldcurtis @benwilson512