Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix quotes around dynamic values in error messages (#142) #144

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix quotes around dynamic values in error messages (#142) #144

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/absinthe/relay/node.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,13 +194,13 @@ defmodule Absinthe.Relay.Node do
defp do_from_global_id({type_name, id}, schema) do
case schema.__absinthe_type__(type_name) do
nil ->
{:error, "Unknown type `#{type_name}'"}
{:error, "Unknown type `#{type_name}`"}

%{identifier: ident, interfaces: interfaces} ->
if Enum.member?(List.wrap(interfaces), :node) do
{:ok, %{type: ident, id: id}}
else
{:error, "Type `#{type_name}' is not a valid node type"}
{:error, "Type `#{type_name}` is not a valid node type"}
end
end
end
Expand Down
2 changes: 1 addition & 1 deletion lib/absinthe/relay/node/id_translator/base64.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ defmodule Absinthe.Relay.Node.IDTranslator.Base64 do
end

:error ->
{:error, "Could not decode ID value `#{global_id}'"}
{:error, "Could not decode ID value `#{global_id}`"}
end
end
end