Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for use with kernel 5.8.x #338

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

omegacoleman
Copy link
Contributor

@omegacoleman omegacoleman commented Aug 17, 2020

I wasn't aware of #337 when i started, but this fix for sha256_state might be more simple.
Also needs #333 #316 5.3 5.6 patches for working with 5.8.x kernel

@omegacoleman
Copy link
Contributor Author

omegacoleman commented Aug 27, 2020

the origin version got bugs after hours of using it with my device. after I encountered https://lore.kernel.org/linux-wireless/[email protected]/ I realised that though the function looks useless to me (it only prints some logs) it somehow could not be removed (as a 'registration function'). I fixed it and it now works perfectly.

@paralin
Copy link

paralin commented Sep 9, 2020

Hi all,

Currently Buildroot is based on 4235b0e with this patch and #316 applied.

My version of this series of patches on top of 4235b as a base is here: https://github.com/paralin/rtl8812AU_8821AU_linux/tree/buildroot

Hope this helps.

@paralin
Copy link

paralin commented Sep 9, 2020

making some progress there, but still running into another problem:

../rtl8821au-4235b0ec7d7220a6364586d8e25b1e8cb99c36f1/os_dep/linux/rtw_proc.c: In function ‘rtw_proc_create_entry’:
../rtl8821au-4235b0ec7d7220a6364586d8e25b1e8cb99c36f1/os_dep/linux/rtw_proc.c:73:67: error: passing argument 4 of ‘proc_create_data’ from incompatible pointer type [-Werror=incompatible-pointer-types]
   73 |  entry = proc_create_data(name,  S_IFREG|S_IRUGO|S_IWUGO, parent, fops, data);
      |                                                                   ^~~~
      |                                                                   |
      |                                                                   const struct file_operations *
In file included from ../rtl8821au-4235b0ec7d7220a6364586d8e25b1e8cb99c36f1/include/../os_dep/linux/rtw_proc.h:23,
                 from ../rtl8821au-4235b0ec7d7220a6364586d8e25b1e8cb99c36f1/include/osdep_intf.h:123,
                 from ../rtl8821au-4235b0ec7d7220a6364586d8e25b1e8cb99c36f1/include/drv_types.h:107,
                 from ../rtl8821au-4235b0ec7d7220a6364586d8e25b1e8cb99c36f1/os_dep/linux/rtw_proc.c:21:
./include/linux/proc_fs.h:102:31: note: expected ‘const struct proc_ops *’ but argument is of type ‘const struct file_operations *’
  102 | extern struct proc_dir_entry *proc_create_data(const char *, umode_t,

@omegacoleman
Copy link
Contributor Author

hi @paralin , that's great to hear. I made a typo in the original description actually, and fails to indicate that #333 is needed too. This error is due to fops being splited from procfs and is fixed there.

@paralin
Copy link

paralin commented Sep 13, 2020

@omegacoleman yup my branch + series submitted to buildroot mainline has that in there too

@Ecos-hj
Copy link

Ecos-hj commented Jan 11, 2021

Your version works for me, too.
So we shall prefer it, (EDIT: we still need a fix for Kernel 5.10)

@omegacoleman
Copy link
Contributor Author

@Ecos-hj Thanks for letting me know.

The 5.10+ builds break because of the famous removal of set_fs() on x86_64. I issued a PR for that #345, and this branch I tested works for 5.10+ https://github.com/omegacoleman/rtl8812AU_8821AU_linux/tree/kernel-5.10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants