Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Groundwater Arsenic Content Detection #983

Merged
merged 31 commits into from
Nov 10, 2024

Conversation

Stuti333
Copy link
Contributor

@Stuti333 Stuti333 commented Nov 9, 2024

Pull Request for DL-Simplified 💡

Issue Title : Addition of Groundwater arsenic content detection

  • Info about the related issue (Aim of the project) : To detect arsenic content of groundwater and detect whether it is useful or harmful
  • Name: Stuti Sharma
  • GitHub ID: https://github.com/Stuti333
  • Email ID: [email protected]
  • Idenitfy yourself: (Mention in which program you are contributing in. Eg. For a JWOC 2022 participant it's, JWOC Participant) GSSOC'EXT Participant

Closes: #960

Describe the add-ons or changes you've made 📃

Added a new model with 3 methods to detect groundwater quality

Type of change ☑️

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested? ⚙️

Describe how it has been tested: Tested on sample datas and calculated accuracy of the algorithms used

Checklist: ☑️

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added things that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

Copy link

github-actions bot commented Nov 9, 2024

Our team will soon review your PR. Thanks @Stuti333 :)

Copy link
Owner

@abhisheks008 abhisheks008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Project folder name should be, Groundwater Arsenic Content Detection.
  2. Follow the README template and update the README.md file. For your reference, https://github.com/abhisheks008/DL-Simplified/blob/main/.github/readme_template.md
  3. Change the .py files in to ipynb files (mandatory required).
  4. Folder names should be in Title Case (Dataset, Models, Images etc.)

@Stuti333

@abhisheks008 abhisheks008 changed the title Added the new model Groundwater Arsenic Content Detection Nov 10, 2024
@abhisheks008
Copy link
Owner

Do let me know once you are done with the update.
@Stuti333

@Stuti333
Copy link
Contributor Author

Stuti333 commented Nov 10, 2024

I have made all the required changes kindly review it @abhisheks008

Copy link
Owner

@abhisheks008 abhisheks008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!!
@Stuti333

@abhisheks008 abhisheks008 added Status: Approved Approved PR by the PA. level 2 Level 2 for GSSOC and removed Status: Requested Changes Changes requested. labels Nov 10, 2024
@abhisheks008 abhisheks008 merged commit c84d5a4 into abhisheks008:main Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc-ext level 2 Level 2 for GSSOC Points Updated Status: Approved Approved PR by the PA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Addition of Groundwater arsenic content detection
2 participants