Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New EDA to Amazon Reviews Sentiment Analysis #941

Merged
merged 7 commits into from
Oct 25, 2024

Conversation

SimranShaikh20
Copy link
Contributor

@SimranShaikh20 SimranShaikh20 commented Oct 23, 2024

Pull Request for DL-Simplified 💡

Issue no - #915

Issue Title :

Adding some charts for better understanding

  • Info about the related issue (Aim of the project) : Easy to understand

  • Name: Simran Shaikh

  • GitHub ID: @SimranShaikh20

  • Idenitfy yourself: (Mention in which program you are contributing in. Eg. For a JWOC 2022 participant it's, JWOC Participant) GSSOC ' 24 extd

Describe the add-ons or changes you've made 📃

add notebook file to main branch
Give a clear description of what have you added or modifications made

Type of change ☑️

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)

How Has This Been Tested? ⚙️

Describe how it has been tested
Describe how have you verified the changes made

Checklist: ☑️

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added things that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

Copy link

Our team will soon review your PR. Thanks @SimranShaikh20 :)

@SimranShaikh20
Copy link
Contributor Author

@abhisheks008 if there is conflicts let me know !

@SimranShaikh20
Copy link
Contributor Author

@abhisheks008 please merged my PR !

Copy link
Owner

@abhisheks008 abhisheks008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put the file in the designated project folder, it should not be in the main repository's home page!!

@SimranShaikh20

@SimranShaikh20
Copy link
Contributor Author

SimranShaikh20 commented Oct 25, 2024

Please put the file in the designated project folder, it should not be in the main repository's home page!!

@SimranShaikh20

Okay I will make changes

@SimranShaikh20
Copy link
Contributor Author

@abhisheks008 i had added file in to particular pls review it .
And is there any confilcts then let me know

Copy link
Owner

@abhisheks008 abhisheks008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put the file inside the Model folder.

Copy link
Contributor Author

@SimranShaikh20 SimranShaikh20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abhisheks008 added file in model folder

Copy link
Owner

@abhisheks008 abhisheks008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Approved!
@SimranShaikh20

@abhisheks008 abhisheks008 added Status: Approved Approved PR by the PA. level 1 Level 1 for GSSOC hacktoberfest-accepted hacktoberfest and removed Status: Requested Changes Changes requested. labels Oct 25, 2024
@abhisheks008 abhisheks008 merged commit cd120d1 into abhisheks008:main Oct 25, 2024
@SimranShaikh20
Copy link
Contributor Author

@abhisheks008 can you please change level!
Is as I implement entire eda concept in it

@abhisheks008
Copy link
Owner

abhisheks008 commented Oct 26, 2024

@abhisheks008 can you please change level! Is as I implement entire eda concept in it

Model implementations will carry Level 2 and above. You can try out another issue for model implementations and get the desired level.

Please share your email address for further communications.

@SimranShaikh20
Copy link
Contributor Author

@abhisheks008 can you please change level! Is as I implement entire eda concept in it

Model implementations will carry Level 2 and above. You can try out another issue for model implementations and get the desired level.

Please share your email address for further communications.

yeah sure

[email protected]

@SimranShaikh20
Copy link
Contributor Author

SimranShaikh20 commented Oct 26, 2024

@abhisheks008 points updated label meaning i had not understand can you pls ellobrate it !

@abhisheks008
Copy link
Owner

@abhisheks008 points updated label meaning i had not understand can you pls ellobrate it !

I always track an excel sheet for having a count on the PRs merged and the points assigned to the contributors along with their emails for further communications.

Points Updated signifies that your points have been recorded to my excel sheet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: New EDA to Amazon Reviews Sentiment Analysis
2 participants