forked from smartcontractkit/ccip
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DirectBurn on RemotePool #21
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
contracts/src/v0.8/ccip/pools/GHO/UpgradeableBurnMintTokenPool.sol
Outdated
Show resolved
Hide resolved
contracts/src/v0.8/ccip/pools/GHO/UpgradeableBurnMintTokenPool.sol
Outdated
Show resolved
Hide resolved
contracts/src/v0.8/ccip/pools/GHO/UpgradeableBurnMintTokenPool.sol
Outdated
Show resolved
Hide resolved
DhairyaSethi
changed the title
Withdraw liquidity on RemotePool
DirectBurn on RemotePool
Dec 23, 2024
contracts/src/v0.8/ccip/pools/GHO/UpgradeableBurnMintTokenPool.sol
Outdated
Show resolved
Hide resolved
contracts/src/v0.8/ccip/pools/GHO/UpgradeableBurnMintTokenPool.sol
Outdated
Show resolved
Hide resolved
….sol Co-authored-by: miguelmtz <[email protected]>
….sol Co-authored-by: miguelmtz <[email protected]>
miguelmtzinf
approved these changes
Dec 23, 2024
Merged
miguelmtzinf
approved these changes
Dec 24, 2024
This PR was verified by Certora team. No bugs or issues were found. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Remote Token Pool (UpgradeableBurnMintTokenPool):
Adds GHO-Specific onlyOwner
directBurn
which burns liquidity & reduces facilitator level.Does not add
directMint
since it is being introduced now and the 1.4 tokens are going to be deprecated in favour of 1.5.1 pools (see referenced AIP aave/aave-proposals-v3#19).